From 2d1a4067190c3619f5998bebe75b118e4d282cc5 Mon Sep 17 00:00:00 2001 From: Tania Allard Date: Thu, 26 May 2022 17:57:34 +0100 Subject: [PATCH 1/4] :wrench: Gitpod to use the Docker image --- .github/workflows/docker.yml | 2 +- .gitpod.yml | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 2259f3c8..d772c75f 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -10,7 +10,7 @@ jobs: name: Build Gitpod Docker image runs-on: ubuntu-latest environment: a11y-dev - if: "github.repository_owner == 'Quansight-Labs' && !contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.event.head_commit.message, '[skip github]')" + if: "github.repository_owner == 'jupyter' && !contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.event.head_commit.message, '[skip github]')" steps: - name: Clone repository ⚡ uses: actions/checkout@v3 diff --git a/.gitpod.yml b/.gitpod.yml index b2ae493e..e65a94c1 100644 --- a/.gitpod.yml +++ b/.gitpod.yml @@ -1,12 +1,13 @@ -image: - file: testing/tools/gitpod/Dockerfile +image: quansight/jupyter-a11y:latest tasks: - name: Install JupyterLab Node.js testing dependencies init: | cd testing/jupyterlab + echo " 📦 Installing node dependencies " yarn install cd workspace/a11y + echo "🚀 All ready" # -------------------------------------------------------- # exposing ports From 08aaeab3a71f2fc38d46ba240683361ae400ed5a Mon Sep 17 00:00:00 2001 From: Tania Allard Date: Fri, 27 May 2022 13:31:50 +0100 Subject: [PATCH 2/4] :heavy_plus_sign: Update dependencies install --- .gitpod.yml | 3 ++- testing/tools/Dockerfile | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitpod.yml b/.gitpod.yml index e65a94c1..393d2e0f 100644 --- a/.gitpod.yml +++ b/.gitpod.yml @@ -6,7 +6,8 @@ tasks: cd testing/jupyterlab echo " 📦 Installing node dependencies " yarn install - cd workspace/a11y + npx playwright install + cd workspace/accessibility echo "🚀 All ready" # -------------------------------------------------------- diff --git a/testing/tools/Dockerfile b/testing/tools/Dockerfile index 167830cc..04e7e76e 100644 --- a/testing/tools/Dockerfile +++ b/testing/tools/Dockerfile @@ -30,7 +30,6 @@ ARG JUPYTER_APP=jupyterlab # base HOME for all things in gitpod ENV DEBIAN_FRONTEND=noninteractive ENV GITPOD_HOME=/home/gitpod \ - WORKSPACE=/workspace/a11y \ USER=gitpod \ GITPOD_GIUD=33333 From 3ccdd9fa8ec623bb74c20c604835350ad3ed92fd Mon Sep 17 00:00:00 2001 From: Tania Allard Date: Fri, 27 May 2022 13:34:11 +0100 Subject: [PATCH 3/4] :pencil2: Fix md warning --- testing/jupyterlab/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testing/jupyterlab/README.md b/testing/jupyterlab/README.md index 36149d55..eb57532d 100644 --- a/testing/jupyterlab/README.md +++ b/testing/jupyterlab/README.md @@ -55,7 +55,7 @@ by modifying the [`playwright.config.ts`](testing/jupyterlab/playwright.config.t ``` Your console should output a local URL that you can open in your browser to see -the test results: typically http://127.0.0.1:9323 +the test results: typically ### :cloud: Running in Gitpod From daf142708a2c5f1966b1a2d3a5c824881ede7246 Mon Sep 17 00:00:00 2001 From: Tania Allard Date: Fri, 27 May 2022 12:43:28 +0000 Subject: [PATCH 4/4] Add vscode extensions --- .gitpod.yml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/.gitpod.yml b/.gitpod.yml index 393d2e0f..534fe02f 100644 --- a/.gitpod.yml +++ b/.gitpod.yml @@ -7,8 +7,8 @@ tasks: echo " 📦 Installing node dependencies " yarn install npx playwright install - cd workspace/accessibility - echo "🚀 All ready" + echo "🚀 Dependencies installed " + cd /workspace/accessibility/ # -------------------------------------------------------- # exposing ports @@ -16,6 +16,14 @@ ports: - port: 9323 - port: 8888 +# some useful extensions to have +vscode: + extensions: + - eamodio.gitlens + - ms-python.python + - yzhang.markdown-all-in-one + - bungcip.better-toml + # -------------------------------------------------------- # using prebuilds for the container # With this configuration the prebuild will happen on push to master @@ -36,6 +44,6 @@ github: # need to change addComment: false # add a "Review in Gitpod" button to the pull request's description (defaults to false) - addBadge: false + addBadge: true # add a label once the prebuild is ready to pull requests (defaults to false) addLabel: false