Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify shared components between Retrolab and Jlab #68

Closed
trallard opened this issue Dec 17, 2021 · 2 comments
Closed

Identify shared components between Retrolab and Jlab #68

trallard opened this issue Dec 17, 2021 · 2 comments
Assignees
Labels
area: testing ☑️ Testing related issues or tasks type: scoping 🔎 Used to scope a project, implementation or evaluate steps moving forward
Milestone

Comments

@trallard
Copy link
Member

trallard commented Dec 17, 2021

Summary

@gabalafou will be working on discovering the shared components between JLab and Retrolab to drive #4

Acceptance Criteria

@trallard trallard added type: scoping 🔎 Used to scope a project, implementation or evaluate steps moving forward area: testing ☑️ Testing related issues or tasks labels Dec 17, 2021
@trallard trallard added this to the 📌 6-months milestone Dec 17, 2021
@gabalafou
Copy link
Contributor

After taking a long time deep-diving into JupyterLab so that I could truly understand how it loads itself into the browser, I was able to do a comparatively quick comparison between RetroLab and JupyterLab.

Based on the above work, these are the conclusions I have come to so far. Perhaps wediscuss them in our next team meeting?

  • tl;dr-- from my perspective, there’s very little new code in RetroLab to target for our accessibility work. It looks like RetroLab mostly re-arranges and omits UI elements from JupyterLab.
  • So my take is: we should focus on JupyterLab while thinking about how our changes there will bubble up to RetroLab while at the same time being open to making changes to JupyterLab (and Lumino) that will allow RetroLab to customize the elements it inherits from JupyterLab so that they make sense and are more accessible within the context of the RetroLab UX

@trallard
Copy link
Member Author

Marking as complete, but creating two following issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: testing ☑️ Testing related issues or tasks type: scoping 🔎 Used to scope a project, implementation or evaluate steps moving forward
Projects
Status: Done 💪🏾
Development

No branches or pull requests

2 participants