Add FFT functions #50

prasunanand · 2020-03-07T17:30:58Z

Resolves #49

WIP

hameerabbasi · 2020-03-10T10:24:46Z

@peterbell10 Would it be possible for you to look into this segfault? Unless it's from Python or PyTest, it may be in uarray.

peterbell10 · 2020-03-10T12:59:11Z

unumpy/tests/test_numpy.py

+        (np.fft.fftfreq, (10), {}),
+        (np.fft.rfftfreq, (10), {}),


These are missing the commas that makes args a tuple.

Suggested change

(np.fft.fftfreq, (10), {}),

(np.fft.rfftfreq, (10), {}),

(np.fft.fftfreq, (10,), {}),

(np.fft.rfftfreq, (10,), {}),

I think that code coverage may be crashing because the ast is invalid?

Actually, a bunch of the lists above are missing the comma as well.

Well, the AST is valid, just that *a isn't valid when a isn't a sequence or iterable, which is a runtime error.

Add FFT functions

0fe8d76

prasunanand requested a review from hameerabbasi March 7, 2020 17:30

peterbell10 reviewed Mar 10, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add FFT functions #50

Add FFT functions #50

prasunanand commented Mar 7, 2020

hameerabbasi commented Mar 10, 2020

peterbell10 Mar 10, 2020

peterbell10 Mar 10, 2020

hameerabbasi Mar 10, 2020 •

edited

Loading

Add FFT functions #50

Are you sure you want to change the base?

Add FFT functions #50

Conversation

prasunanand commented Mar 7, 2020

hameerabbasi commented Mar 10, 2020

peterbell10 Mar 10, 2020

Choose a reason for hiding this comment

peterbell10 Mar 10, 2020

Choose a reason for hiding this comment

hameerabbasi Mar 10, 2020 • edited Loading

Choose a reason for hiding this comment

hameerabbasi Mar 10, 2020 •

edited

Loading