Salt highstate generation doesn’t work on Fedora templates

[DemiMarie]

Qubes OS version

Qubes release 4.0 (R4.0)

Affected component(s) or functionality

mgmt-salt

Brief summary

All attempts to invoke state.highstate on Fedora qubes fail with an error message about rendering top files.

How Reproducible

100%

To Reproduce

Steps to reproduce the behavior:

1. Upgrade Fedora qube to the latest version, enabling updates-testing for security updates (only).
2. Run sudo qubesctl --target=fedora-33 --skip-dom0 -- state.highstate
3. Check the results

Expected behavior

Salt states are run

Actual behavior

An error

Screenshots

Additional context

Solutions you've tried

I have tried modifying my Salt states, with no luck.

Relevant documentation you've consulted

Related, non-duplicate issues

[unman]

Salt does work, as evidenced by fact that GUI updater works for fedora-33. Also, you can `state.apply` states without issue. It looks as if this error is specific to generating highstate in fedora-33. Is enabling updates-testing important? I think not.

[DemiMarie]

Salt does work, as evidenced by fact that GUI updater works for fedora-33. Also, you can state.apply states without issue. It looks as if this error is specific to generating highstate in fedora-33. Is enabling updates-testing important? I think not.

It is, indeed, specific to highstate generation. I have over a thousand lines of Salt last I checked, so this is rather annoying.

[unman]

On Tue, May 04, 2021 at 10:22:01AM -0700, Demi Marie Obenour wrote: > Salt does work, as evidenced by fact that GUI updater works for fedora-33. Also, you can `state.apply` states without issue. It looks as if this error is specific to generating highstate in fedora-33. Is enabling updates-testing important? I think not. It is, indeed, specific to highstate generation. I have over a thousand lines of Salt last I checked, so this is rather annoying.

After a little poking around with templates and highstate. fedora-33 as template for default-mgmt-dvm throws this same error re top file, against many targets. Using fedora-32 as template works fine, except where target is fedora-33, when the top file error is reported. In both cases, state.apply with specific state works fine - that's my default use.

[marmarek]

It seems to be this issue: saltstack/salt#60003

I've posted a workaround patch there (to be applied in default-mgmt-dvm's template).

[marmarek]

This is specifically regression between salt-3002.6-1.fc33 and salt-3003-1.fc33. A failing test: https://openqa.qubes-os.org/tests/17154#step/TC_10_VMSalt_fedora-33/2

[qubesos-bot]

Automated announcement from builder-github

The package qubes-mgmt-salt-4.1.11-1.fc32 has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package mgmt-salt has been pushed to the r4.1 testing repository for the CentOS centos8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-mgmt-salt_4.1.11-1 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing buster-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The component mgmt-salt (including package qubes-mgmt-salt-4.1.11-1.fc32) has been pushed to the r4.1 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-mgmt-salt-4.0.25-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-mgmt-salt-4.1.11-1.fc32 has been pushed to the r4.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The component mgmt-salt (including package qubes-mgmt-salt-4.0.25-1.fc32) has been pushed to the r4.0 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package mgmt-salt has been pushed to the r4.0 stable repository for the CentOS centos8 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-mgmt-salt_4.0.25-1+deb10u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[eloquence]

@marmarek We're now longer seeing version 4.0.25 in https://yum.qubes-os.org/r4.0/current/vm/fc33/rpm/ , which is a blocker for a clean transition of our users to fedora-33. We also noticed downtime of the repo earlier this week - possibly related?

[marmarek]

Yes, related. Let me re-upload the package.

[marmarek]

Done.