Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question(maybe bug) about EMA #1

Open
Emperorizzis opened this issue Jun 9, 2024 · 0 comments
Open

Question(maybe bug) about EMA #1

Emperorizzis opened this issue Jun 9, 2024 · 0 comments

Comments

@Emperorizzis
Copy link

【Question in EN】
Hi! Thank you very much for the open-source work!

I have two questions regarding EMA in the code you implemented:
1) I noticed that in run_dpo_om.sh (L440), you tried to import EMAAdamW using from .optimizers import EMAAdamW, but EMAAdamW is not defined in optimizers.py. Is this a bug?
2) In run_dpo_om.sh (L157), you used --use_merge ${USE_EMA} to assign USE_EMA to use_merge. Did you mean to set both --use_merge True and --use_ema True at the same time?

Looking forward to your reply!


【Question in ZH】
Hi ! 非常感谢您工作的开源!

在您实现的代码中,关于EMA我有两个问题想请教您:
1) 我注意到在run_dpo_om.sh (L440),您使用from .optimizers import EMAAdamW尝试引入EMAAdamW,但optimizers.py中并未定义EMAAdamW这是否是一个bug?
2)run_dpo_om.sh (L157),您使用--use_merge ${USE_EMA}USE_EMA赋值到use_merge您是否想同时设定--use_merge True--use_ema True

期待您的回复!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant