Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features are not additive #73

Open
tcharding opened this issue Oct 16, 2023 · 2 comments
Open

Features are not additive #73

tcharding opened this issue Oct 16, 2023 · 2 comments

Comments

@tcharding
Copy link
Contributor

tcharding commented Oct 16, 2023

The features are not additive, this means running cargo test --all-features doesn't work.

The problem is the electrs/esplora features used to define VERSION, perhaps there is another way?

#[cfg(feature = "electrs_0_8_10")]
const VERSION: &str = "v0.8.10";

#[cfg(feature = "esplora_a33e97e1")]
const VERSION: &str = "esplora_a33e97e1a1fc63fa9c20a116bb92579bbf43b254";

#[cfg(feature = "electrs_0_9_1")]
const VERSION: &str = "v0.9.1";

#[cfg(feature = "electrs_0_9_11")]
const VERSION: &str = "v0.9.11";
@RCasatta
Copy link
Owner

Yes, Andrew fixed this in bitcoins with a clever approach rust-bitcoin/bitcoind#117
It needs to be ported also here

@RCasatta
Copy link
Owner

Mmmh, here we also have the issue of esplora_a33e97e1 which is not strictly growing but forking...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants