Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethernet: Missing multicast addr assignment #13493

Open
JannesVolkens opened this issue Feb 27, 2020 · 5 comments · Fixed by #15287
Open

ethernet: Missing multicast addr assignment #13493

JannesVolkens opened this issue Feb 27, 2020 · 5 comments · Fixed by #15287
Assignees
Labels
Area: drivers Area: Device drivers Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: question The issue poses a question regarding usage of RIOT

Comments

@JannesVolkens
Copy link
Contributor

Description

PR #13383 fixed the unicast filtering for stm32, but at the same time blocked the filtering of multicast addresses. However, since NDP maps to a multicast address, the neighbor table remained empty, which prevented the sending of IPv6 packets.
PR #13487 then fixed this issue by reactivating the passing of all frames with a multicast address.

So far, an adequate multicast address assignment is missing in RIOT so that the stm32 has to filter for every frame containing a multicast address.

Useful links

None.

@kfessel
Copy link
Contributor

kfessel commented Feb 27, 2020

Here is a list of Protocolls using Ethernet Group-Messages (Multicast)

https://en.wikipedia.org/wiki/Multicast_address#Ethernet

@PeterKietzmann PeterKietzmann changed the title cpu/stm32: Missing multicast addr assignment ethernet: Missing multicast addr assignment Feb 28, 2020
@PeterKietzmann PeterKietzmann added Area: drivers Area: Device drivers Area: network Area: Networking Type: question The issue poses a question regarding usage of RIOT labels Feb 28, 2020
@PeterKietzmann
Copy link
Member

I've changed the title because this is a general question to all Ethernet interfaces aka driver implementations. How do we deal with multicast address assignment? Most devices seem to have more or less advanced filter rules but if I see it correctly, we rely on always receiving all multicast traffic (e.g. triggered from ICMPv6 control traffic) on a node. This is inefficient. Do have have a convention for that, a piece of documentation or has Ethernet multicast address assignment just not been looked at?

@kfessel
Copy link
Contributor

kfessel commented Feb 28, 2020

this may seem inefficient but it is not less efficient than dealing with the same but in Braodcasts (which afaik IPv4 ARP does)

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Jul 6, 2020
@miri64 miri64 added this to the Release 2020.07 milestone Jul 6, 2020
@miri64
Copy link
Member

miri64 commented Oct 23, 2020

See #15287 for a provided framework within GNRC (there is no device support in that PR however, that I leave to people who like to read data sheets ;-))

@miri64
Copy link
Member

miri64 commented Oct 29, 2020

#15287 did not fix the issue. There is still driver support required for that.

@miri64 miri64 reopened this Oct 29, 2020
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: question The issue poses a question regarding usage of RIOT
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants