Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_networking: offers txtsnd, does not print received packets #5034

Closed
miri64 opened this issue Mar 11, 2016 · 21 comments
Closed

gnrc_networking: offers txtsnd, does not print received packets #5034

miri64 opened this issue Mar 11, 2016 · 21 comments
Assignees
Labels
Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Comments

@miri64
Copy link
Member

miri64 commented Mar 11, 2016

gnrc_networking is offering the txtsnd command but does not print it results when receiving a packet. Overall this is a good situation (the application would otherwise get spammed with link layer packet output), but it might be confusing for new users. I'm voting to remove the txtsnd command from shell_commands an put it only in the applications were it is needed, as partly proposes in #2755.

@miri64 miri64 added the ugly label Mar 11, 2016
@miri64 miri64 added this to the Release 2016.04 milestone Mar 11, 2016
@OlegHahm
Copy link
Member

Against removing txtsnd from shell commands. It's a very helpful debug tool.

@miri64
Copy link
Member Author

miri64 commented Mar 11, 2016

Even if there is no information printed at the receiver?

An alternative would be to introduce a dump command that would allow to activate the "dumpage" of a certain nettype.

@OlegHahm
Copy link
Member

Yes, even without - I can still see it in Wireshark - or in the debug output of my networking modules. ;)

@OlegHahm
Copy link
Member

To be clear: I see your general point and I second it.

@haukepetersen
Copy link
Contributor

I would not remove it, how about a txtrcv command, that waits exactly for 1 network packet to arrive and the prints this?

@miri64
Copy link
Member Author

miri64 commented Mar 11, 2016

You mean link layer packet. But this still might be confusing, since any network layer packet (Neighbor solicitations, RPL DIOs etc.) would also be printed and preempt the packet the user was originally expecting... I would opt more for a activatable/deactivatable solution.

@OlegHahm
Copy link
Member

Hm, difficult, particular, if you have additional traffic on the wire. On native, for instance, even the default example sees a lot of traffic on the link layer, stemming from the host system.

@haukepetersen
Copy link
Contributor

Isn't the txtsnd only compiled into the default example (without further network stack)?

@miri64
Copy link
Member Author

miri64 commented Mar 11, 2016

Nope, it's compiled into any application, that uses the gnrc_netif module.

@haukepetersen
Copy link
Contributor

ok, then forgot what I proposed :-)

@OlegHahm
Copy link
Member

But maybe you have a good point: how about making the txtsnd command optional and disable it per default? This would go into the direction of @authmillenon's initial proposal, but still make it available for debugging purposes if needed.

@haukepetersen
Copy link
Contributor

another dumb idea: how about to put a proprietary header (like RIOT in ASCII) in front of the data send via txtsnd. This could be easily parsed by the receiver...

@haukepetersen
Copy link
Contributor

hm, now that I though about his again: why don't we just drop txtsnd from the gnrc_networking example? If you want to focus on link layer only communication, use the default example instead?

@OlegHahm
Copy link
Member

Hm, doesn't this go back to the initial discussion?

@haukepetersen
Copy link
Contributor

won't be fixed for this release -> set Milestone to 2016.07

@haukepetersen haukepetersen modified the milestones: Release 2016.07, Release 2016.04 Apr 20, 2016
@OlegHahm
Copy link
Member

OlegHahm commented Jun 1, 2016

Hm, actually, I would be okay with dropping txtsnd from gnrc_networking example, but I'm still against removing the shell command. Anybody objects putting it into a separate module and include it only for default example?

@miri64
Copy link
Member Author

miri64 commented Jun 1, 2016

No objections.

@kYc0o
Copy link
Contributor

kYc0o commented Jul 26, 2016

No objections, but please address it for the next release :)

@kYc0o kYc0o modified the milestones: Release 2016.10, Release 2016.07 Jul 26, 2016
@miri64 miri64 modified the milestones: Release 2017.01, Release 2016.10 Oct 31, 2016
@OlegHahm OlegHahm self-assigned this Jan 10, 2017
@LudwigKnuepfer
Copy link
Member

LudwigKnuepfer commented Jan 10, 2017

Just to add some beef to the discussion which I did not read:
being able to txtsnd with happening on the receiving side is very confusing.

@OlegHahm
Copy link
Member

<theo-de-raadt-mode>Slackers!</theo-de-raadt-mode>

@OlegHahm
Copy link
Member

see #6397

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation and removed quality defect labels Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

No branches or pull requests

5 participants