-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc_networking: offers txtsnd, does not print received packets #5034
Comments
Against removing txtsnd from shell commands. It's a very helpful debug tool. |
Even if there is no information printed at the receiver? An alternative would be to introduce a dump command that would allow to activate the "dumpage" of a certain nettype. |
Yes, even without - I can still see it in Wireshark - or in the debug output of my networking modules. ;) |
To be clear: I see your general point and I second it. |
I would not remove it, how about a |
You mean link layer packet. But this still might be confusing, since any network layer packet (Neighbor solicitations, RPL DIOs etc.) would also be printed and preempt the packet the user was originally expecting... I would opt more for a activatable/deactivatable solution. |
Hm, difficult, particular, if you have additional traffic on the wire. On native, for instance, even the default example sees a lot of traffic on the link layer, stemming from the host system. |
Isn't the |
Nope, it's compiled into any application, that uses the |
ok, then forgot what I proposed :-) |
But maybe you have a good point: how about making the txtsnd command optional and disable it per default? This would go into the direction of @authmillenon's initial proposal, but still make it available for debugging purposes if needed. |
another dumb idea: how about to put a proprietary header (like |
hm, now that I though about his again: why don't we just drop |
Hm, doesn't this go back to the initial discussion? |
won't be fixed for this release -> set Milestone to 2016.07 |
Hm, actually, I would be okay with dropping |
No objections. |
No objections, but please address it for the next release :) |
Just to add some beef to the discussion which I did not read: |
<theo-de-raadt-mode>Slackers!</theo-de-raadt-mode> |
see #6397 |
gnrc_networking
is offering thetxtsnd
command but does not print it results when receiving a packet. Overall this is a good situation (the application would otherwise get spammed with link layer packet output), but it might be confusing for new users. I'm voting to remove thetxtsnd
command fromshell_commands
an put it only in the applications were it is needed, as partly proposes in #2755.The text was updated successfully, but these errors were encountered: