Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: shell: split WLAN/WPAN specific options into own command #5487

Closed
miri64 opened this issue Jun 1, 2016 · 20 comments
Closed

RFC: shell: split WLAN/WPAN specific options into own command #5487

miri64 opened this issue Jun 1, 2016 · 20 comments
Labels
Area: network Area: Networking Community: good first issue This issue is good for newcomers to RIOT to be addressed / implemented Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: stale State: The issue / PR has no activity for >185 days Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Comments

@miri64
Copy link
Member

miri64 commented Jun 1, 2016

ifconfig is starting to get really complicated and I'm thinking about splitting some radio specific options into their own command (similar to Linux' iwconfig and iwpan). Opinions?

@miri64 miri64 added Area: network Area: Networking Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR labels Jun 1, 2016
@jfischer-no
Copy link
Contributor

iwpan for 802.15.4 and iwconfig for 802.11 ?

@OlegHahm
Copy link
Member

OlegHahm commented Jun 1, 2016

iwconfig was deprecated alredy 5 years ago - we should rather go for iw then.

@jfischer-no
Copy link
Contributor

then iwpan for 802.15.4 and iw for 802.11

@miri64
Copy link
Member Author

miri64 commented Jun 1, 2016

Yes, for example.

@jfischer-no
Copy link
Contributor

What about not ieee std devices like cc110x?

@OlegHahm
Copy link
Member

OlegHahm commented Jun 1, 2016

Do we really need to split this up for different radio technologies? Most properties (channel, TX power, network identifier) should be rather similar for most technologies.

@miri64
Copy link
Member Author

miri64 commented Jun 1, 2016

Yes most, but as #5469 already shows, there are some that can even be very specific for vendors.

@OlegHahm
Copy link
Member

OlegHahm commented Jun 1, 2016

But that's (as you wrote yourself) vendor specific, not specific to the technology and would prefer to keep the number of shell commands small. Even for 802.11 chips on Linux you'll find a broad variety of available options, but (fortunately) only one tool.

@jfischer-no
Copy link
Contributor

I am on iwpan, will add it to #5485

@miri64
Copy link
Member Author

miri64 commented Jun 1, 2016

@jfischer-phytec-iot can you please introduce it in a seperate PR and just adapt it in #5485? It will make the review more focused this way.

@miri64
Copy link
Member Author

miri64 commented Jun 1, 2016

Also, when push comes to shove I'm for iw instead of iwpan ;-).

@jfischer-no
Copy link
Contributor

@miri64 ok

@PeterKietzmann
Copy link
Member

#5750 was closed 2 years ago. Since then, there were no efforts for a change. Furthermore, we continued caring about ifconfig. Personally I think we could close this issue (maybe set memo label) and admit we stay with ifconfig. @miri64 any objections?

@miri64
Copy link
Member Author

miri64 commented Feb 21, 2019

Seeing the amount of new information added to ifconfig, I'm still of the opinion that we actually should factor out certain options that are only of importance for certain devices. However, since this is a low priority (at least to me), we should keep this issue open as a reminder for that / opportunity for a newcomer to implement that. What do you think @PeterKietzmann?

@miri64 miri64 added the Community: good first issue This issue is good for newcomers to RIOT to be addressed / implemented label Feb 21, 2019
@PeterKietzmann
Copy link
Member

Personally I don't think this will ever happen, although it might be worth it. But I'm fine leaving the issue open. However, I don't think this is something that should be done by a newcomer.

@stale
Copy link

stale bot commented Aug 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 25, 2019
@stale stale bot closed this as completed Sep 25, 2019
@miri64
Copy link
Member Author

miri64 commented Sep 25, 2019

#12295 gave some new precedence to this. @jia200x @benpicco what do you think?

@miri64 miri64 reopened this Sep 25, 2019
@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Sep 25, 2019
@miri64 miri64 added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Sep 25, 2019
@benpicco
Copy link
Contributor

benpicco commented Sep 25, 2019

#12171 will add even more radio commands to ifconfig.

I too agree that it would be a good idea to have separate commands for layer 1/2 and layer 3.

@jia200x
Copy link
Member

jia200x commented Sep 25, 2019

+1. Indeed!

@stale
Copy link

stale bot commented Mar 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Mar 28, 2020
@stale stale bot closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Community: good first issue This issue is good for newcomers to RIOT to be addressed / implemented Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: stale State: The issue / PR has no activity for >185 days Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

No branches or pull requests

6 participants