Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ieee802154: Intra-pan packet headers are constructed incorrectly #5684

Closed
aeneby opened this issue Jul 24, 2016 · 4 comments
Closed

ieee802154: Intra-pan packet headers are constructed incorrectly #5684

aeneby opened this issue Jul 24, 2016 · 4 comments
Assignees
Labels
Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@aeneby
Copy link
Member

aeneby commented Jul 24, 2016

When sending intra-pan packets (i.e. packets where the source and destination PANs are identical), the source PAN should be omitted from the header and the "intra-pan" bit set to 1. From the 802.15.4-2003 spec (page 154):

If the PAN identifiers are identical, the intra-PAN subfield of the frame control field shall be set to 1, and the source PAN identifier shall be omitted from the transmitted frame.

Currently, drivers using RIOT's ieee802154 implementation are sending out intra-pan packets with both source and destination PANs in the header, and the "intra-pan" bit set to 0, even though the PANs are identical. Linux will actually drop these incorrectly constructed packets.

@OlegHahm OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking labels Jul 24, 2016
@aeneby
Copy link
Member Author

aeneby commented Jul 25, 2016

#5685

@mojiuyu
Copy link

mojiuyu commented Jul 25, 2016

dear aeneby : Sorry,my english is not very good.I want to use the radio frequency functions cc2538.Can you show me the example of it?

@aeneby
Copy link
Member Author

aeneby commented Jul 25, 2016

@mojiuyu your question is outside the scope of this issue, please try asking on the RIOT users' mailing list instead.

@miri64
Copy link
Member

miri64 commented Oct 18, 2016

Fixed in #5897

@miri64 miri64 closed this as completed Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

No branches or pull requests

5 participants