Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some lpm implementation do not follow docs #6202

Closed
lebrush opened this issue Dec 12, 2016 · 1 comment
Closed

Some lpm implementation do not follow docs #6202

lebrush opened this issue Dec 12, 2016 · 1 comment
Assignees
Labels
Area: doc Area: Documentation Area: pm Area: (Low) power management Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@lebrush
Copy link
Member

lebrush commented Dec 12, 2016

The LPM notification indicates that the lpm_arch_set method shall return the mode which was actually set. However, some implementations (stm32f2, stm32f1, any maybe others) return the previous mode to the one which was set.

 64 /**
 65  * @brief Try to set the controller to a given power mode
 66  *
 67  * @param[in] target    the desired power mode
 68  *
 69  * @return              the power mode that was actually set
 70  */
 71 enum lpm_mode lpm_arch_set(enum lpm_mode target);

Either the documentation needs to be updated or the code fixed.
This probably expires once #6160 (or relevant) is merged.

@OlegHahm OlegHahm added Area: pm Area: (Low) power management Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: doc Area: Documentation labels Dec 12, 2016
@lebrush
Copy link
Member Author

lebrush commented Jan 19, 2017

This can be closed since #6160 got merged.

@lebrush lebrush closed this as completed Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: pm Area: (Low) power management Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

No branches or pull requests

3 participants