Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/fmt: Missing tests for fmt_float, fmt_lpad #7220

Closed
jnohlgard opened this issue Jun 21, 2017 · 4 comments
Closed

sys/fmt: Missing tests for fmt_float, fmt_lpad #7220

jnohlgard opened this issue Jun 21, 2017 · 4 comments
Assignees
Labels
Area: tests Area: tests and testing framework Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@jnohlgard
Copy link
Member

See title.
Also, fmt_float has a bug where it will skip over a byte before the decimal point in the middle of the output string if the number is negative because of a mistake in the output pointer advancement.

@jnohlgard jnohlgard added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework labels Jun 21, 2017
@jnohlgard jnohlgard added this to the Release 2017.07 milestone Jun 21, 2017
@kaspar030
Copy link
Contributor

+1, but fmt_lpad() does have some unittests?

@jnohlgard
Copy link
Member Author

Maybe I missed it while I was scanning the source. But fmt_float needs some tests at least

@stale
Copy link

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@stale stale bot closed this as completed Sep 10, 2019
@aabadie aabadie reopened this Sep 21, 2019
@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Sep 21, 2019
@MrKevinWeiss MrKevinWeiss added the State: don't stale State: Tell state-bot to ignore this issue label Nov 22, 2019
@miri64 miri64 added this to the Release 2020.07 milestone Jul 1, 2020
@aabadie aabadie removed the State: don't stale State: Tell state-bot to ignore this issue label May 20, 2021
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
@maribu
Copy link
Member

maribu commented Sep 16, 2022

lpad is covered in the unit tests, tests/fmt_print tests print_float() which indirectly tests fmt_float().

@maribu maribu closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

No branches or pull requests

6 participants