Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

periph/rtc breaks nucleo-l152 #8240

Closed
kYc0o opened this issue Dec 11, 2017 · 5 comments · Fixed by #8545
Closed

periph/rtc breaks nucleo-l152 #8240

kYc0o opened this issue Dec 11, 2017 · 5 comments · Fixed by #8545
Labels
Impact: major The PR changes a significant part of the code base. It should be reviewed carefully State: duplicate State: The issue/PR is a duplicate of another issue/PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Milestone
Release 2018.01

Comments

@kYc0o
Copy link
Contributor

kYc0o commented Dec 11, 2017

While re-testing #7712 I realised that it didn't work at all, then I tested other examples and nothing seems to work.

After bisecting and looking everywhere, I realised that #6900 was the culprit. Unfortunately I didn't have time to dig more into the issue, so I don't know exactly with commit is the real cause of the crash.

Even if I revert the changes, my PR still not work, but I'm investigating if there are more bugs related to this platform.
@kYc0o kYc0o added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: major The PR changes a significant part of the code base. It should be reviewed carefully labels Dec 11, 2017
@kYc0o kYc0o added this to the Release 2018.01 milestone Dec 11, 2017
@aabadie
Copy link
Contributor

aabadie commented Dec 11, 2017

Yes nucleo-l152 doesn't work actually, as reported in #7687, see comment. Maybe your problem is related to this ?

@aabadie
Copy link
Contributor

aabadie commented Dec 11, 2017

Also realized that there's already an issue here: #8024. Duplicate ?

@kYc0o
Copy link
Contributor Author

kYc0o commented Dec 11, 2017

Definitely this is a duplicate... however I realised that reverting #6900 actually solves the problem for the basic examples. I'll try to move the discussion in those PR/issues. Please don't close this one until that's done.

@kaspar030
Copy link
Contributor

duplicate

@kaspar030 kaspar030 added the State: duplicate State: The issue/PR is a duplicate of another issue/PR label Dec 15, 2017
@kYc0o kYc0o mentioned this issue Dec 25, 2017
Closed
@kYc0o
Copy link
Contributor Author

kYc0o commented Dec 25, 2017

I just made the reference on #8024, I didn't want to close this without having it related to it. Now it's ok.

@kYc0o kYc0o mentioned this issue Jan 16, 2018
Closed
@kYc0o kYc0o mentioned this issue Feb 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Impact: major The PR changes a significant part of the code base. It should be reviewed carefully State: duplicate State: The issue/PR is a duplicate of another issue/PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2018.01
3 participants
@aabadie @kaspar030 @kYc0o