From e6f349ebfc35a6a9e1bd5a97f865074c9f946d96 Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Tue, 17 Jul 2018 19:29:27 +0200 Subject: [PATCH 01/13] ieee802154: Add defines for default device flags --- sys/include/net/ieee802154.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sys/include/net/ieee802154.h b/sys/include/net/ieee802154.h index 5d833b8498db..527554ecb6a1 100644 --- a/sys/include/net/ieee802154.h +++ b/sys/include/net/ieee802154.h @@ -135,6 +135,18 @@ extern const uint8_t ieee802154_addr_bcast[IEEE802154_ADDR_BCAST_LEN]; #ifndef IEEE802154_DEFAULT_TXPOWER #define IEEE802154_DEFAULT_TXPOWER (0) /* in dBm */ #endif + +#ifndef IEEE802154_DEFAULT_ENABLE_ACK_REQ +#define IEEE802154_DEFAULT_ENABLE_ACK_REQ (1) +#endif + +#ifndef IEEE802154_DEFAULT_ENABLE_AUTOACK +#define IEEE802154_DEFAULT_ENABLE_AUTOACK (1) +#endif + +#ifndef IEEE802154_DEFAULT_ENABLE_CSMA +#define IEEE802154_DEFAULT_ENABLE_CSMA (1) +#endif /** @} */ /** From 4669a6d53c7357380ddabc21c34cd71cc1737cbd Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Tue, 17 Jul 2018 19:46:36 +0200 Subject: [PATCH 02/13] gnrc_netif: Support for ieee802154 init flags This adds support to GNRC for enabling radio flags on device initialization --- sys/net/gnrc/netif/gnrc_netif.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/sys/net/gnrc/netif/gnrc_netif.c b/sys/net/gnrc/netif/gnrc_netif.c index f672ac4205e6..316159a3c7f1 100644 --- a/sys/net/gnrc/netif/gnrc_netif.c +++ b/sys/net/gnrc/netif/gnrc_netif.c @@ -1281,6 +1281,29 @@ static void _init_from_device(gnrc_netif_t *netif) _update_l2addr_from_dev(netif); } +static void _configure_netdev_802154(netdev_t *dev) +{ + netopt_enable_t enable = NETOPT_ENABLE; + if (IEEE802154_DEFAULT_ENABLE_ACK_REQ) { + int res = dev->driver->set(dev, NETOPT_ACK_REQ, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable ACK requests failed: %d\n", res); + } + } + if (IEEE802154_DEFAULT_ENABLE_AUTOACK) { + int res = dev->driver->set(dev, NETOPT_AUTOACK, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable auto ACK failed: %d\n", res); + } + } + if (IEEE802154_DEFAULT_ENABLE_CSMA) { + int res = dev->driver->set(dev, NETOPT_CSMA, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable CSMA failed: %d\n", res); + } + } +} + static void _configure_netdev(netdev_t *dev) { /* Enable RX- and TX-complete interrupts */ @@ -1295,6 +1318,16 @@ static void _configure_netdev(netdev_t *dev) DEBUG("gnrc_netif: enable NETOPT_TX_END_IRQ failed: %d\n", res); } #endif + + uint16_t dev_type; + res = dev->driver->get(dev, NETOPT_DEVICE_TYPE, &dev_type, sizeof(dev_type)); + assert(res == sizeof(dev_type)); + + switch(dev_type) { + case NETDEV_TYPE_IEEE802154: + _configure_netdev_802154(dev); + break; + } } static void *_gnrc_netif_thread(void *args) From 1093e2afcf0dc64fd837176b46870a7a59558a53 Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Tue, 17 Jul 2018 19:54:40 +0200 Subject: [PATCH 03/13] lwip: Support for ieee802154 init flags This adds support to LwIP for enabling radio flags on device initialization --- pkg/lwip/contrib/netdev/lwip_netdev.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/pkg/lwip/contrib/netdev/lwip_netdev.c b/pkg/lwip/contrib/netdev/lwip_netdev.c index 73ec8190c658..4b27cd4cfa68 100644 --- a/pkg/lwip/contrib/netdev/lwip_netdev.c +++ b/pkg/lwip/contrib/netdev/lwip_netdev.c @@ -60,6 +60,29 @@ static err_t _ieee802154_link_output(struct netif *netif, struct pbuf *p); static void _event_cb(netdev_t *dev, netdev_event_t event); static void *_event_loop(void *arg); +static void _configure_netdev_802154(netdev_t *dev) +{ + netopt_enable_t enable = NETOPT_ENABLE; + if (IEEE802154_DEFAULT_ENABLE_ACK_REQ) { + int res = dev->driver->set(dev, NETOPT_ACK_REQ, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable ACK requests failed: %d\n", res); + } + } + if (IEEE802154_DEFAULT_ENABLE_AUTOACK) { + int res = dev->driver->set(dev, NETOPT_AUTOACK, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable auto ACK failed: %d\n", res); + } + } + if (IEEE802154_DEFAULT_ENABLE_CSMA) { + int res = dev->driver->set(dev, NETOPT_CSMA, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable CSMA failed: %d\n", res); + } + } +} + static void _configure_netdev(netdev_t *dev) { /* Enable RX-complete interrupts */ @@ -132,6 +155,8 @@ err_t lwip_netdev_init(struct netif *netif) { u16_t val; ip6_addr_t *addr; + + _configure_netdev_802154(netdev); if (netdev->driver->get(netdev, NETOPT_NID, &val, sizeof(val)) < 0) { return ERR_IF; From ed32575779efb91128e3f477bf1ef803d1bcccf7 Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Tue, 17 Jul 2018 19:58:29 +0200 Subject: [PATCH 04/13] emb6: Support for ieee802154 init flags This adds support to emb6 for enabling radio flags on device initialization --- pkg/emb6/contrib/netdev/emb6_netdev.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/pkg/emb6/contrib/netdev/emb6_netdev.c b/pkg/emb6/contrib/netdev/emb6_netdev.c index ded613a650e2..9fcf73a11339 100644 --- a/pkg/emb6/contrib/netdev/emb6_netdev.c +++ b/pkg/emb6/contrib/netdev/emb6_netdev.c @@ -19,6 +19,7 @@ #include "msg.h" #include "net/netdev.h" +#include "net/ieee802154.h" #include "evproc.h" #include "emb6.h" @@ -116,6 +117,24 @@ static void _configure_netdev(void) if (res < 0) { DEBUG("emb6: enable NETOPT_RX_END_IRQ failed: %d\n", res); } + if (IEEE802154_DEFAULT_ENABLE_ACK_REQ) { + res = _dev->driver->set(_dev, NETOPT_ACK_REQ, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable ACK requests failed: %d\n", res); + } + } + if (IEEE802154_DEFAULT_ENABLE_AUTOACK) { + res = _dev->driver->set(_dev, NETOPT_AUTOACK, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable auto ACK failed: %d\n", res); + } + } + if (IEEE802154_DEFAULT_ENABLE_CSMA) { + res = _dev->driver->set(_dev, NETOPT_CSMA, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable CSMA failed: %d\n", res); + } + } } int emb6_netdev_setup(netdev_t *dev) From 0960e1a025e8fd6f505b124649df120fa7c19ed5 Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Wed, 18 Jul 2018 15:40:15 +0200 Subject: [PATCH 05/13] fixup! gnrc_netif: Support for ieee802154 init flags --- sys/net/gnrc/netif/gnrc_netif.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/net/gnrc/netif/gnrc_netif.c b/sys/net/gnrc/netif/gnrc_netif.c index 316159a3c7f1..31bc4c94d0f0 100644 --- a/sys/net/gnrc/netif/gnrc_netif.c +++ b/sys/net/gnrc/netif/gnrc_netif.c @@ -1281,9 +1281,10 @@ static void _init_from_device(gnrc_netif_t *netif) _update_l2addr_from_dev(netif); } +#ifdef MODULE_NETDEV_IEEE802154 static void _configure_netdev_802154(netdev_t *dev) { - netopt_enable_t enable = NETOPT_ENABLE; + static const netopt_enable_t enable = NETOPT_ENABLE; if (IEEE802154_DEFAULT_ENABLE_ACK_REQ) { int res = dev->driver->set(dev, NETOPT_ACK_REQ, &enable, sizeof(enable)); if (res < 0) { @@ -1303,6 +1304,7 @@ static void _configure_netdev_802154(netdev_t *dev) } } } +#endif /* MODULE_NETDEV_IEEE802154 */ static void _configure_netdev(netdev_t *dev) { @@ -1324,9 +1326,11 @@ static void _configure_netdev(netdev_t *dev) assert(res == sizeof(dev_type)); switch(dev_type) { +#ifdef MODULE_NETDEV_IEEE802154 case NETDEV_TYPE_IEEE802154: _configure_netdev_802154(dev); break; +#endif /* MODULE_NETDEV_IEEE802154 */ } } From 68dabb65b2992bff29c762727db5a48e7090dcd1 Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Wed, 18 Jul 2018 15:40:30 +0200 Subject: [PATCH 06/13] fixup! lwip: Support for ieee802154 init flags --- pkg/lwip/contrib/netdev/lwip_netdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/lwip/contrib/netdev/lwip_netdev.c b/pkg/lwip/contrib/netdev/lwip_netdev.c index 4b27cd4cfa68..1c174ca2b180 100644 --- a/pkg/lwip/contrib/netdev/lwip_netdev.c +++ b/pkg/lwip/contrib/netdev/lwip_netdev.c @@ -60,9 +60,10 @@ static err_t _ieee802154_link_output(struct netif *netif, struct pbuf *p); static void _event_cb(netdev_t *dev, netdev_event_t event); static void *_event_loop(void *arg); +#ifdef MODULE_LWIP_SIXLOWPAN static void _configure_netdev_802154(netdev_t *dev) { - netopt_enable_t enable = NETOPT_ENABLE; + static const netopt_enable_t enable = NETOPT_ENABLE; if (IEEE802154_DEFAULT_ENABLE_ACK_REQ) { int res = dev->driver->set(dev, NETOPT_ACK_REQ, &enable, sizeof(enable)); if (res < 0) { @@ -82,6 +83,7 @@ static void _configure_netdev_802154(netdev_t *dev) } } } +#endif /* MODULE_LWIP_SIXLOWPAN */ static void _configure_netdev(netdev_t *dev) { From ddd3c48b4c1196893edfcad291a08912b7a4e585 Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Thu, 19 Jul 2018 11:01:09 +0200 Subject: [PATCH 07/13] fixup! gnrc_netif: Support for ieee802154 init flags --- sys/net/gnrc/netif/gnrc_netif.c | 37 ---------------------- sys/net/gnrc/netif/gnrc_netif_ieee802154.c | 27 ++++++++++++++++ 2 files changed, 27 insertions(+), 37 deletions(-) diff --git a/sys/net/gnrc/netif/gnrc_netif.c b/sys/net/gnrc/netif/gnrc_netif.c index 31bc4c94d0f0..f672ac4205e6 100644 --- a/sys/net/gnrc/netif/gnrc_netif.c +++ b/sys/net/gnrc/netif/gnrc_netif.c @@ -1281,31 +1281,6 @@ static void _init_from_device(gnrc_netif_t *netif) _update_l2addr_from_dev(netif); } -#ifdef MODULE_NETDEV_IEEE802154 -static void _configure_netdev_802154(netdev_t *dev) -{ - static const netopt_enable_t enable = NETOPT_ENABLE; - if (IEEE802154_DEFAULT_ENABLE_ACK_REQ) { - int res = dev->driver->set(dev, NETOPT_ACK_REQ, &enable, sizeof(enable)); - if (res < 0) { - DEBUG("gnrc_netif: enable ACK requests failed: %d\n", res); - } - } - if (IEEE802154_DEFAULT_ENABLE_AUTOACK) { - int res = dev->driver->set(dev, NETOPT_AUTOACK, &enable, sizeof(enable)); - if (res < 0) { - DEBUG("gnrc_netif: enable auto ACK failed: %d\n", res); - } - } - if (IEEE802154_DEFAULT_ENABLE_CSMA) { - int res = dev->driver->set(dev, NETOPT_CSMA, &enable, sizeof(enable)); - if (res < 0) { - DEBUG("gnrc_netif: enable CSMA failed: %d\n", res); - } - } -} -#endif /* MODULE_NETDEV_IEEE802154 */ - static void _configure_netdev(netdev_t *dev) { /* Enable RX- and TX-complete interrupts */ @@ -1320,18 +1295,6 @@ static void _configure_netdev(netdev_t *dev) DEBUG("gnrc_netif: enable NETOPT_TX_END_IRQ failed: %d\n", res); } #endif - - uint16_t dev_type; - res = dev->driver->get(dev, NETOPT_DEVICE_TYPE, &dev_type, sizeof(dev_type)); - assert(res == sizeof(dev_type)); - - switch(dev_type) { -#ifdef MODULE_NETDEV_IEEE802154 - case NETDEV_TYPE_IEEE802154: - _configure_netdev_802154(dev); - break; -#endif /* MODULE_NETDEV_IEEE802154 */ - } } static void *_gnrc_netif_thread(void *args) diff --git a/sys/net/gnrc/netif/gnrc_netif_ieee802154.c b/sys/net/gnrc/netif/gnrc_netif_ieee802154.c index 60036a40852a..57b236a9b171 100644 --- a/sys/net/gnrc/netif/gnrc_netif_ieee802154.c +++ b/sys/net/gnrc/netif/gnrc_netif_ieee802154.c @@ -29,10 +29,12 @@ #endif #ifdef MODULE_NETDEV_IEEE802154 +static void _init(gnrc_netif_t *netif); static int _send(gnrc_netif_t *netif, gnrc_pktsnip_t *pkt); static gnrc_pktsnip_t *_recv(gnrc_netif_t *netif); static const gnrc_netif_ops_t ieee802154_ops = { + .init = _init, .send = _send, .recv = _recv, .get = gnrc_netif_get_from_netdev, @@ -74,6 +76,31 @@ static gnrc_pktsnip_t *_make_netif_hdr(uint8_t *mhr) return snip; } +static void _init(gnrc_netif_t *netif) +{ + /* Enable compile time default settings in the driver */ + static const netopt_enable_t enable = NETOPT_ENABLE; + netdev_t *dev = netif->dev; + if (IEEE802154_DEFAULT_ENABLE_ACK_REQ) { + int res = dev->driver->set(dev, NETOPT_ACK_REQ, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable ACK requests failed: %d\n", res); + } + } + if (IEEE802154_DEFAULT_ENABLE_AUTOACK) { + int res = dev->driver->set(dev, NETOPT_AUTOACK, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable auto ACK failed: %d\n", res); + } + } + if (IEEE802154_DEFAULT_ENABLE_CSMA) { + int res = dev->driver->set(dev, NETOPT_CSMA, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable CSMA failed: %d\n", res); + } + } +} + static gnrc_pktsnip_t *_recv(gnrc_netif_t *netif) { netdev_t *dev = netif->dev; From 84e9b6d93955a33d4b4af42a93ea433d9e90754c Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Fri, 9 Nov 2018 12:26:25 +0100 Subject: [PATCH 08/13] openthread: Support for ieee802154 init flags ACK_REQ and AUTOACK are always forced on independent of the settings as Openthread requires that these are enabled. --- .../contrib/netdev/openthread_netdev.c | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/pkg/openthread/contrib/netdev/openthread_netdev.c b/pkg/openthread/contrib/netdev/openthread_netdev.c index 862290a98136..994044ad34ec 100755 --- a/pkg/openthread/contrib/netdev/openthread_netdev.c +++ b/pkg/openthread/contrib/netdev/openthread_netdev.c @@ -59,6 +59,28 @@ void otTaskletsSignalPending(otInstance *aInstance) { (void) aInstance; } +static void _configure_netdev_ieee802154(netdev_t *dev) +{ + static const netopt_enable_t enable = NETOPT_ENABLE; + + /* Always enable ACK_REQ and AUTOACK for Openthread */ + int res = dev->driver->set(dev, NETOPT_ACK_REQ, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable ACK requests failed: %d\n", res); + } + res = dev->driver->set(dev, NETOPT_AUTOACK, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable auto ACK failed: %d\n", res); + } + + if (IEEE802154_DEFAULT_ENABLE_CSMA) { + int res = dev->driver->set(dev, NETOPT_CSMA, &enable, sizeof(enable)); + if (res < 0) { + DEBUG("gnrc_netif: enable CSMA failed: %d\n", res); + } + } +} + static void *_openthread_event_loop(void *arg) { (void)arg; _pid = thread_getpid(); @@ -170,6 +192,8 @@ int openthread_netdev_init(char *stack, int stacksize, char priority, netdev->driver->set(netdev, NETOPT_TX_END_IRQ, &enable, sizeof(enable)); netdev->driver->set(netdev, NETOPT_RX_END_IRQ, &enable, sizeof(enable)); + _configure_netdev_ieee802154(netdev); + _pid = thread_create(stack, stacksize, priority, THREAD_CREATE_STACKTEST, _openthread_event_loop, NULL, name); From a44eac176492d65fc90d92bd62c0f2c96a28c89e Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Fri, 9 Nov 2018 12:29:07 +0100 Subject: [PATCH 09/13] cc2538: Remove default autoack flag settings --- cpu/cc2538/radio/cc2538_rf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpu/cc2538/radio/cc2538_rf.c b/cpu/cc2538/radio/cc2538_rf.c index 43fd9b2b6c43..662e64d7a047 100644 --- a/cpu/cc2538/radio/cc2538_rf.c +++ b/cpu/cc2538/radio/cc2538_rf.c @@ -53,7 +53,7 @@ static const init_pair_t init_table[] = { {&RFCORE_XREG_CSPT, 0xff }, {&RFCORE_XREG_MDMCTRL0, 0x85 }, {&RFCORE_XREG_FSCTRL, 0x55 }, - {&RFCORE_XREG_FRMCTRL0, AUTOCRC | AUTOACK }, + {&RFCORE_XREG_FRMCTRL0, AUTOCRC }, {&RFCORE_XREG_FRMCTRL1, 0x00 }, {&RFCORE_XREG_SRCMATCH, 0x00 }, {&RFCORE_XREG_FIFOPCTRL, CC2538_RF_MAX_DATA_LEN }, From 9b71ae0f7349b375903bb48f69757a625f3ee539 Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Fri, 9 Nov 2018 12:29:36 +0100 Subject: [PATCH 10/13] at86rf2xx: Remove default radio flags --- drivers/at86rf2xx/at86rf2xx.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/at86rf2xx/at86rf2xx.c b/drivers/at86rf2xx/at86rf2xx.c index 800616843eac..2b717ffadd36 100644 --- a/drivers/at86rf2xx/at86rf2xx.c +++ b/drivers/at86rf2xx/at86rf2xx.c @@ -79,13 +79,6 @@ void at86rf2xx_reset(at86rf2xx_t *dev) at86rf2xx_set_chan(dev, AT86RF2XX_DEFAULT_CHANNEL); /* set default TX power */ at86rf2xx_set_txpower(dev, AT86RF2XX_DEFAULT_TXPOWER); - /* set default options */ - at86rf2xx_set_option(dev, AT86RF2XX_OPT_AUTOACK, true); - at86rf2xx_set_option(dev, AT86RF2XX_OPT_CSMA, true); - - static const netopt_enable_t enable = NETOPT_ENABLE; - netdev_ieee802154_set(&dev->netdev, NETOPT_ACK_REQ, - &enable, sizeof(enable)); /* enable safe mode (protect RX FIFO until reading data starts) */ at86rf2xx_reg_write(dev, AT86RF2XX_REG__TRX_CTRL_2, From 1c1f25ec85f12e23d3e2311eac4e8f153bcf49dc Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Fri, 9 Nov 2018 12:29:57 +0100 Subject: [PATCH 11/13] cc2420: Remove default radio flags --- drivers/cc2420/cc2420.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/cc2420/cc2420.c b/drivers/cc2420/cc2420.c index 24c159255ab4..b9d63ccdca42 100644 --- a/drivers/cc2420/cc2420.c +++ b/drivers/cc2420/cc2420.c @@ -62,10 +62,6 @@ int cc2420_init(cc2420_t *dev) cc2420_set_chan(dev, CC2420_CHAN_DEFAULT); cc2420_set_txpower(dev, CC2420_TXPOWER_DEFAULT); - /* set default options */ - cc2420_set_option(dev, CC2420_OPT_AUTOACK, true); - cc2420_set_option(dev, CC2420_OPT_CSMA, true); - /* change default RX bandpass filter to 1.3uA (as recommended) */ reg = cc2420_reg_read(dev, CC2420_REG_RXCTRL1); reg |= CC2420_RXCTRL1_RXBPF_LOCUR; From 688dd2a7bbf403154d32ac4cae4463f21227a59e Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Fri, 9 Nov 2018 12:30:19 +0100 Subject: [PATCH 12/13] kw2xrf: Remove default radio flags --- drivers/kw2xrf/kw2xrf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/kw2xrf/kw2xrf.c b/drivers/kw2xrf/kw2xrf.c index 49e85ff1bca0..52c191ff78f6 100644 --- a/drivers/kw2xrf/kw2xrf.c +++ b/drivers/kw2xrf/kw2xrf.c @@ -104,8 +104,6 @@ void kw2xrf_reset_phy(kw2xrf_t *dev) kw2xrf_set_rx_watermark(dev, 1); - kw2xrf_set_option(dev, KW2XRF_OPT_AUTOACK, true); - kw2xrf_set_option(dev, KW2XRF_OPT_ACK_REQ, true); kw2xrf_set_option(dev, KW2XRF_OPT_AUTOCCA, true); kw2xrf_set_power_mode(dev, KW2XRF_AUTODOZE); From e22498acb06ad7439b59857345506841f6e1a18f Mon Sep 17 00:00:00 2001 From: Koen Zandberg Date: Fri, 9 Nov 2018 12:30:32 +0100 Subject: [PATCH 13/13] mrf24j40: Remove default radio flags --- drivers/mrf24j40/mrf24j40.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mrf24j40/mrf24j40.c b/drivers/mrf24j40/mrf24j40.c index 2ae3a30111e3..26d74e3a3a6a 100644 --- a/drivers/mrf24j40/mrf24j40.c +++ b/drivers/mrf24j40/mrf24j40.c @@ -66,8 +66,6 @@ void mrf24j40_reset(mrf24j40_t *dev) /* set default options */ mrf24j40_set_option(dev, IEEE802154_FCF_PAN_COMP, true); mrf24j40_set_option(dev, NETDEV_IEEE802154_SRC_MODE_LONG, true); - mrf24j40_set_option(dev, NETDEV_IEEE802154_ACK_REQ, true); - mrf24j40_set_option(dev, MRF24J40_OPT_CSMA, true); /* go into RX state */ mrf24j40_reset_tasks(dev);