Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Fix C2Rust installation procedure #17504

Merged
merged 1 commit into from
Jan 17, 2022
Merged

doc: Fix C2Rust installation procedure #17504

merged 1 commit into from
Jan 17, 2022

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Jan 12, 2022

Contribution description

The --locked is required since dependencies increased their MSRV to
something later than C2Rust's fixed nightly. That was already reflected
in the riotdocker installation steps, but not here where the line was
taken from upstream's docs.

Testing procedure

Look at built docs.

Issues/PRs references

Closes: #17492

@chrysn
doc: Fix C2Rust installation procedure
acbbb40 
The `--locked` is required since dependencies increased their MSRV to
something later than C2Rust's fixed nightly. That was already reflected
in the riotdocker installation steps, but not here where the line was
taken from upstream's docs.

Closes: RIOT-OS#17492
@github-actions github-actions bot added the Area: doc Area: Documentation label Jan 12, 2022
@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jan 12, 2022
@maribu maribu enabled auto-merge January 17, 2022 16:40
@maribu maribu merged commit d788bd3 into RIOT-OS:master Jan 17, 2022
@chrysn chrysn deleted the doc-c2rust-locked branch January 17, 2022 16:41
JKRhb added a commit to JKRhb/RIOT that referenced this pull request Feb 23, 2022
@JKRhb
doc: Add missing --locked to C2Rust install info
182c5c3 
PR RIOT-OS#17504 missed one `--locked` flag when resolving RIOT-OS#17492
chrysn added a commit to chrysn-pull-requests/RIOT that referenced this pull request Feb 24, 2022
@chrysn
doc/rust: Remove duplicate (and wrong) line
204a622 
The duplication happened already in the initial version, and when
[17504] had the `--locked` added, the opportunity to remove the
duplication was missed.

[17504]: RIOT-OS#17504
@chrysn chrysn mentioned this pull request Feb 24, 2022
Merged
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.

Using Rust doc toolchain info is obsolete
3 participants
@chrysn @maribu @OlegHahm