From 2fb8ef1f0b8dc140c26f4510935cc6a1c481f313 Mon Sep 17 00:00:00 2001 From: Gunar Schorcht Date: Sat, 18 Feb 2023 08:07:28 +0100 Subject: [PATCH 1/2] boards/esp32s2-lilygo-ttgo-t8: fix STDIO selection in Kconfig --- boards/esp32s2-lilygo-ttgo-t8/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/boards/esp32s2-lilygo-ttgo-t8/Kconfig b/boards/esp32s2-lilygo-ttgo-t8/Kconfig index e732c8eb549e..10b9ba3be94c 100644 --- a/boards/esp32s2-lilygo-ttgo-t8/Kconfig +++ b/boards/esp32s2-lilygo-ttgo-t8/Kconfig @@ -28,7 +28,7 @@ config BOARD_ESP32S2_LILYGO_TTGO_T8 select HAVE_MTD_SDCARD_DEFAULT select HAVE_ST7735 select MODULE_FATFS_VFS if MODULE_VFS_DEFAULT - select MODULE_USBUS_CDC_ACM if MODULE_USBUS + select MODULE_USBUS_CDC_ACM if MODULE_USBUS && ESP32S2_LILYGO_TTGO_T8_USB menu "LILYGO TTGO T8 ESP32-S2 Board configurations" depends on BOARD_ESP32S2_LILYGO_TTGO_T8 @@ -54,8 +54,8 @@ menu "LILYGO TTGO T8 ESP32-S2 Board configurations" endmenu choice STDIO_IMPLEMENTATION - default MODULE_STDIO_CDC_ACM if MODULE_USBUS - default MODULE_STDIO_TINYUSB_CDC_ACM if MODULE_TINYUSB_DEVICE + default MODULE_STDIO_CDC_ACM if MODULE_USBUS && ESP32S2_LILYGO_TTGO_T8_USB + default MODULE_STDIO_TINYUSB_CDC_ACM if MODULE_TINYUSB_DEVICE && ESP32S2_LILYGO_TTGO_T8_USB endchoice source "$(RIOTBOARD)/common/esp32s2/Kconfig" From 5207c6fdf840b51d08ebea036feb3259c849f038 Mon Sep 17 00:00:00 2001 From: Gunar Schorcht Date: Sat, 18 Feb 2023 08:29:02 +0100 Subject: [PATCH 2/2] boards/esp32s2-lilygo-ttgo-t8: documentation fix --- boards/esp32s2-lilygo-ttgo-t8/doc.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/boards/esp32s2-lilygo-ttgo-t8/doc.txt b/boards/esp32s2-lilygo-ttgo-t8/doc.txt index 341913e6e34e..f0bd291cab3b 100644 --- a/boards/esp32s2-lilygo-ttgo-t8/doc.txt +++ b/boards/esp32s2-lilygo-ttgo-t8/doc.txt @@ -72,11 +72,11 @@ can also be used by other devices. The LILYGO TTGO T8 ESP32-S2 has a USB-to-UART bridge on board. The USB D-/D+ signals of the USB-C connector are connected via DIP switches either to this USB-to-UART bridge (default) or to GPIO19/GPIO20 of the ESP32-S2. To use the -USB-OTG interface of the ESP32-S2, the USB D-/D+ signals must be connected to +USB OTG interface of the ESP32-S2, the USB D-/D+ signals must be connected to GPIO19 and GPIO20, see section \ref esp32s2_lilygo_ttgo_t8_pinout "Pinout". -If the USB-to-UART bridge is used, module `stdio_cdc_acm` or module -`stdio_tinyusb_cdc_acm` can be enabled to use the USB interface also for the -console. +To use the USB OTG interface also for the console in this case, either the +`stdio_cdc_acm` or the `stdio_tinyusb_cdc_acm` module must be enabled. +This is automatically the case if the USBUS or tinyUSB stack is used. The LILYGO TTGO T8 ESP32-S2 has a 32.768 kHz crystal on the board, which is connected to GPIO15 and GPIO16 via DIP switches (default). The crystal can