Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: gfx1151 removed from 6.3 #2059

Closed
trixirt opened this issue Dec 9, 2024 · 9 comments
Closed

[Issue]: gfx1151 removed from 6.3 #2059

trixirt opened this issue Dec 9, 2024 · 9 comments
Assignees
Labels
triaged The issue has been reviewed by a team member and prioritized

Comments

@trixirt
Copy link

trixirt commented Dec 9, 2024

Problem Description

In 6.2.4, support for gfx1151 was added ex/
https://github.com/ROCm/Tensile/blob/release/rocm-rel-6.2/Tensile/AsmCaps.py#L774

In 6.3.0, it has been removed
https://github.com/ROCm/Tensile/blob/release/rocm-rel-6.3/Tensile/AsmCaps.py#L774

In develop, it is here
https://github.com/ROCm/Tensile/blob/develop/Tensile/AsmCaps.py#L774

Operating System

Fedora Rawhide

CPU

ALL

GPU

ALL

ROCm Version

ROCm 6.3.0

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@darren-amd
Copy link
Contributor

darren-amd commented Dec 11, 2024

Hi @trixirt,

Thanks for reporting this issue! I do see that the support commit was not cherry picked into the 6.3 release branch. Do you currently need support within the 6.3 branch or can you use the develop/6.2.4 branch temporarily until the next release? I can work with the internal team to get it into 6.3 if needed, thanks!

@trixirt
Copy link
Author

trixirt commented Dec 11, 2024

I do not need an immediate fix. I was able to cherry pick the commit from the 6.2 branch and building gfx1151 rocblas looks ok. This will show up in Fedora Rawhide soon.

@TorreZuk
Copy link
Contributor

TorreZuk commented Dec 11, 2024

I've asked the Tensile team to consider fixing, if you cherry pick I hope you used the commit from the rocBLAS tensile_tag.txt from release/rocm-rel-6.3 (which was used for rocBLAS 6.3 build not the Tensile branch). Assume mention of 6.2 was a typo, unless you checked an no other changes went in for 6.3 branch?

@trixirt
Copy link
Author

trixirt commented Dec 11, 2024

@bstefanuk
Copy link
Contributor

Hi @trixirt we will cherry pick the gfx1151 support commit into release/rocm-rel-6.3 through the proper channel in the coming days. I will update back here once the cherry pick is complete. Until then, as @darren-amd mentioned, I would recommend using the 6.2 release branch or the latest develop commit.

Let me know if you run into any issues.

@bstefanuk
Copy link
Contributor

bstefanuk commented Dec 11, 2024

@trixirt for this change I'm intending to target only the release/rocm-rel-6.3 branch, is this sufficient for your needs or do you also need an update to point releases 6.3.0.X?

@bstefanuk bstefanuk self-assigned this Dec 11, 2024
@bstefanuk bstefanuk added triaged The issue has been reviewed by a team member and prioritized and removed under investigation labels Dec 11, 2024
@trixirt
Copy link
Author

trixirt commented Dec 13, 2024

Rawhide is a rolling release, we will pick up the change in 6.3.1 or whenever it lands, so what you are proposing if fine.

@darren-amd
Copy link
Contributor

Hi @trixirt,

The changes have been cherry picked into the 6.3 branch: 5838cf7. Thanks for reporting!

@trixirt
Copy link
Author

trixirt commented Dec 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged The issue has been reviewed by a team member and prioritized
Projects
None yet
Development

No branches or pull requests

5 participants