Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Lack of ROCM_LIBPATCH_VERSION environment variable produces incorrect library name for libamdocl64 #112

Open
AngryLoki opened this issue Dec 7, 2024 · 1 comment

Comments

@AngryLoki
Copy link

Problem Description

Hi,

0ef7e3a added version name to libamdocl64.so. However this change was not documented and had no fallback for distro maintainers, who operate on releases (and don't know such things as "patch version").

When ROCM_LIBPATCH_VERSION environment variable is not specified, build produces library named libamdocl64.so. (with dot on the end - see https://archlinux.org/packages/extra/x86_64/rocm-opencl-runtime/files/ for example). I guess some potential solution would be to add fallback like this:

--- a/opencl/amdocl/CMakeLists.txt
+++ b/opencl/amdocl/CMakeLists.txt
@@ -66,6 +66,8 @@ set(AMDOCL_LIB_VERSION_MAJOR "2")
 set(AMDOCL_LIB_VERSION_MINOR "1")
 if(DEFINED ENV{ROCM_LIBPATCH_VERSION})
   set(AMDOCL_LIB_VERSION_PATCH "${AMDOCL_LIB_VERSION_MAJOR}.${AMDOCL_LIB_VERSION_MINOR}.$ENV{ROCM_LIBPATCH_VERSION}")
+else()
+  set(AMDOCL_LIB_VERSION_PATCH "${AMDOCL_LIB_VERSION_MAJOR}.${AMDOCL_LIB_VERSION_MINOR}")
 endif()
 
 set_target_properties(amdocl PROPERTIES

Operating System

Gentoo

CPU

GPU

ROCm Version

ROCm 6.3.0

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@ppanchad-amd
Copy link

Hi @AngryLoki. Internal ticket has been created to investigate your issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants