Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Create 6.1.x branch #82

Closed
torrance opened this issue May 6, 2024 · 3 comments
Closed

[Issue]: Create 6.1.x branch #82

torrance opened this issue May 6, 2024 · 3 comments
Assignees
Labels
hipcc Related to HIPCC

Comments

@torrance
Copy link

torrance commented May 6, 2024

Problem Description

As per the build guide for NVIDIA systems, I need to check out the $ROCM_BRANCH branch of hipcc.git. e.g.:

      export ROCM_BRANCH=rocm-6.1.x
      git clone -b "$ROCM_BRANCH" https://github.com/ROCm-Developer-Tools/hip.git
      git clone -b "$ROCM_BRANCH" https://github.com/ROCm-Developer-Tools/clr.git
      git clone -b "$ROCM_BRANCH" https://github.com/ROCm-Developer-Tools/HIPCC.git
      git clone -b "$ROCM_BRANCH" https://github.com/ROCm/hipother.git

Currently, however, whilst rocm-6.1.x exists in the other repos, I am forced to check out the rocm-6.0.x branch for HIPCC as this is the latest existing branch.

(Note also the documentation entirely fails to mention the hipother.git branch.)

Please either create a branch to allow consistency in building for NVIDIA or update the build instructions for NVIDIA systems to reflect the correct process.

Operating System

n/a

CPU

n/a

GPU

AMD Instinct MI250X

ROCm Version

ROCm 6.1.0

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@lamb-j
Copy link
Collaborator

lamb-j commented May 6, 2024

Good catch, we do need to update that documentation. I'll kick off that effort.

The new home for HIPCC is at https://github.com/ROCm/llvm-project under the amd/hipcc directory.

The rocm-6.1.x branch you're looking for exists there. Also, under the AMD tab (https://rocm.docs.amd.com/projects/HIP/en/latest/install/build.html), there is a note about hipother.git repository. That should probably be copied to the Nvidia tab too though.

@lamb-j lamb-j self-assigned this May 6, 2024
@lamb-j lamb-j added the hipcc Related to HIPCC label May 6, 2024
@lamb-j lamb-j transferred this issue from ROCm/HIPCC May 14, 2024
@lamb-j
Copy link
Collaborator

lamb-j commented May 22, 2024

See updated instructions here: https://github.com/ROCm/HIP/blob/develop/docs/install/build.rst

We're working on updating https://rocm.docs.amd.com/projects/HIP/en/latest/install/build.html to reflect these changes as well.

HIPCC was used to set the HIP_PLATFORM if none was provided. However, if you provide HIP_PLATFORM=amd|nvidia to cmake, you can omit the HIPCC build and paths

@lamb-j
Copy link
Collaborator

lamb-j commented Jun 7, 2024

Thanks again for bringing this up!

See updated instructions here https://rocm.docs.amd.com/projects/HIP/en/latest/install/build.html

@lamb-j lamb-j closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hipcc Related to HIPCC
Projects
None yet
Development

No branches or pull requests

2 participants