From 22a293c19fedb247717a84fa95d3bd34d00c4b3f Mon Sep 17 00:00:00 2001 From: xuchen-amd Date: Mon, 16 Sep 2024 20:51:54 -0400 Subject: [PATCH] Remove MI308X identification using num CUs, and format Python using black. --- src/omniperf_base.py | 6 +++--- src/omniperf_soc/soc_base.py | 5 +---- src/utils/specs.py | 4 ++-- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/omniperf_base.py b/src/omniperf_base.py index 7276e3f6..50a6cf00 100644 --- a/src/omniperf_base.py +++ b/src/omniperf_base.py @@ -56,9 +56,9 @@ } MI300_CHIP_IDS = { - "29856" : "MI300A_A1", - "29857" : "MI300X_A1", - "29858" : "MI308X", + "29856": "MI300A_A1", + "29857": "MI300X_A1", + "29858": "MI308X", } diff --git a/src/omniperf_soc/soc_base.py b/src/omniperf_soc/soc_base.py index 29996431..6083a9cf 100644 --- a/src/omniperf_soc/soc_base.py +++ b/src/omniperf_soc/soc_base.py @@ -159,7 +159,7 @@ def populate_mspec(self): key = search(r"^\s*Chip ID:\s+ ([a-zA-Z0-9]+)\s*", linetext) if key != None: self._mspec.chip_id = key - continue + continue key = search(r"^\s*Max Waves Per CU:\s+ ([a-zA-Z0-9]+)\s*", linetext) if key != None: @@ -200,9 +200,6 @@ def populate_mspec(self): or "MI300X" in self.check_arch_override() ): self._mspec.gpu_model = "MI300X_A1" - # We need to distinguish MI308X by peeking reported num CUs - elif self._mspec.cu_per_gpu == "80" or "MI308X" in self.check_arch_override(): - self._mspec.gpu_model = "MI308X" # Use Chip ID to distinguish the gpu model by using built-in dictionary elif self._mspec.chip_id in MI300_CHIP_IDS: self._mspec.chip_id = MI300_CHIP_IDS[self._mspec.chip_id] diff --git a/src/utils/specs.py b/src/utils/specs.py index 57c5b70a..07938bcf 100644 --- a/src/utils/specs.py +++ b/src/utils/specs.py @@ -406,10 +406,10 @@ class MachineSpecs: chip_id: str = field( default=None, metadata={ - "doc":"<>", + "doc": "<>", "name": "Chip ID", }, - ) + ) max_waves_per_cu: str = field( default=None, metadata={