Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop instrumentation option does not appear to be instrumenting loops #21

Closed
jrmadsen opened this issue Jun 6, 2022 · 0 comments · Fixed by #32
Closed

Loop instrumentation option does not appear to be instrumenting loops #21

jrmadsen opened this issue Jun 6, 2022 · 0 comments · Fixed by #32
Labels
binary instrumentation Binary instrumentation bug Something isn't working omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter)

Comments

@jrmadsen
Copy link
Collaborator

jrmadsen commented Jun 6, 2022 •
edited
Loading

It appears that the -l / --instrument-loops option to the omnitrace binary instrumenter is no longer generating instrumentation around the loops. This regression likely arose during the refactoring to support code coverage. Testing needs to be devised to prevent this regression in the future.
@jrmadsen jrmadsen added bug Something isn't working omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter) binary instrumentation Binary instrumentation labels Jun 6, 2022
@jrmadsen jrmadsen changed the title omnitrace loop instrumentation does not appear to do anything Loop instrumentation option does not appear to be instrumenting loops Jun 6, 2022
@jrmadsen jrmadsen mentioned this issue Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binary instrumentation Binary instrumentation bug Something isn't working omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix loop-level instrumentation + more jrmadsen/omnitrace
1 participant
@jrmadsen