Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

driverInitialized check not valid #102

Closed
mrusme opened this issue Mar 27, 2022 · 4 comments · May be fixed by #104
Closed

driverInitialized check not valid #102

mrusme opened this issue Mar 27, 2022 · 4 comments · May be fixed by #104
Labels
enhancement Under Investigation

Comments

@mrusme
Copy link

mrusme commented Mar 27, 2022

This check is not valid since one can have the GPU module baked into the kernel. In that case, lsmod//proc/modules won't report it.
@littlewu2508
Copy link

ROCm/rocminfo#42 (comment) may help

littlewu2508 added a commit to littlewu2508/rocm_smi_lib that referenced this issue Apr 2, 2022
@littlewu2508
Check /sys/module/amdgpu for ROCk instead of lsmod
dc2a4b5 
Closes: ROCm#102

Signed-off-by: YiyangWu <xgreenlandforwyy@gmail.com>
@littlewu2508 littlewu2508 mentioned this issue Apr 2, 2022
Open
@dmitrii-galantsev
Copy link
Collaborator

Fixed as of 9f6614e. Please reopen if you disagree :)

littlewu2508 added a commit to littlewu2508/rocm_smi_lib that referenced this issue Jan 1, 2024
@littlewu2508
Just check /sys/module/amdgpu if initstate not present
f95cde2 
In case amdgpu is builtin

Closes: ROCm#102

Signed-off-by: YiyangWu <xgreenlandforwyy@gmail.com>
littlewu2508 added a commit to littlewu2508/rocm_smi_lib that referenced this issue Jan 1, 2024
@littlewu2508
Just check /sys/module/amdgpu if initstate not present
fe96886 
In case amdgpu is builtin

Closes: ROCm#102

Signed-off-by: YiyangWu <xgreenlandforwyy@gmail.com>
LtdJorge added a commit to LtdJorge/rocm_smi_lib that referenced this issue Aug 5, 2024
@LtdJorge
Updates driverInitialized() to support amdgpu built as module as well…
0ab16c2 
… as kernel built-in. Fixes ROCm#102 and is an updated version of ROCm#104
@LtdJorge LtdJorge mentioned this issue Aug 5, 2024
Closed
@LtdJorge
Copy link
Contributor

Hi @dmitrii-galantsev could you check #189 out? It's based on @littlewu2508's #104 and simplifies the code a bit by not spawning a shell, as @keryell mentioned in that PR.

I patched my rocm-smi with this:
image
(Ignore the weird path, just Gentoo things)

It works correctly:
image

My AMDGPU is built-in:
image

@taylding-amd
Copy link

Thank you very much for the PR, @LtdJorge! I will go ahead and close the issue, as the PR will resolve it and will be merged through AMD's internal system.

rocm-ci pushed a commit to ROCm/amdsmi that referenced this issue Nov 6, 2024
@LtdJorge @dmitrii-galantsev
Updates driverInitialized() to support amdgpu built as module as well…
172a3e2 
… as kernel built-in. Fixes ROCm/rocm_smi_lib#102 and is an updated version of ROCm/rocm_smi_lib#104

Change-Id: Icb3abe820bc67035b822358a1c04bd09a7c22b6b
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
Reviewed-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
rocm-ci pushed a commit that referenced this issue Nov 6, 2024
@LtdJorge @dmitrii-galantsev
Updates driverInitialized() to support amdgpu built as module as well…
35c1d00 
… as kernel built-in. Fixes #102 and is an updated version of #104

Change-Id: Icb3abe820bc67035b822358a1c04bd09a7c22b6b
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
Reviewed-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Under Investigation
Projects
None yet
Milestone
No milestone
6 participants
@mrusme @dmitrii-galantsev @LtdJorge @littlewu2508 @ppanchad-amd @taylding-amd