Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Upgrade of junit runner fails #4004

Closed
cwisniew opened this issue Apr 26, 2023 · 0 comments · Fixed by #4005
Closed

[Bug]: Upgrade of junit runner fails #4004

cwisniew opened this issue Apr 26, 2023 · 0 comments · Fixed by #4005
Assignees
@cwisniew
Labels
bug

Comments

@cwisniew
Copy link
Member

cwisniew commented Apr 26, 2023 •
edited
Loading

Describe the Bug

JUnit does not support private @BeforeAll / @afterall tests, even though documented as such it was only recently that these tests started failing. This is the cause of #3992 failing.

To Reproduce

Try applying #3992 and running tests

Expected Behaviour

Updating the junit runner should not case tests to fail

Screenshots

No response

MapTool Info

No response

Desktop

No response

Additional Context

No response
@cwisniew cwisniew added the bug label Apr 26, 2023
@cwisniew cwisniew self-assigned this Apr 26, 2023
@cwisniew cwisniew mentioned this issue Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwisniew cwisniew

Labels
bug
Projects
MapTool 1.14.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix junit test cwisniew/maptool
1 participant
@cwisniew