Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Diamond and Hollow Diamond VBL tools have incorrect tool tip #4027

Closed
cwisniew opened this issue May 5, 2023 · 4 comments · Fixed by #4029
Closed

[Bug]: Diamond and Hollow Diamond VBL tools have incorrect tool tip #4027

cwisniew opened this issue May 5, 2023 · 4 comments · Fixed by #4029
Assignees
Labels

Comments

@cwisniew
Copy link
Member

cwisniew commented May 5, 2023

Describe the Bug

The Diamond and Hollow Diamond VBL tools have incorrect tooltips and instructions.

To Reproduce

Hover the mouse pointer over either the Diamond or Hollow Diamond VBL tools

Expected Behaviour

The tool tip and instructions should refer to diamond rather than rectangle.

Screenshots

No response

MapTool Info

MapTool 1.13.0

Desktop

All

Additional Context

No response

@cwisniew cwisniew added the bug label May 5, 2023
@cwisniew cwisniew self-assigned this May 5, 2023
@kwvanderlinde
Copy link
Collaborator

I don't think it's really the tooltip that is wrong here. These tools do draw rectangles, for ISO maps specifcally. Their use on other maps seems very niche given how particular the shape the is.

It would be better to do one of:

  1. Enable/disable the tools depending on the map type
  2. Update the tooltip to say they are for ISO specifically.
  3. Both of the above.

@kwvanderlinde
Copy link
Collaborator

The real bug IMO is that the drawing tools and FoW tool are both labels as drawing "diamonds" rather than ISO rectangles.

@cwisniew
Copy link
Member Author

cwisniew commented May 6, 2023

The real bug IMO is that the drawing tools and FoW tool are both labels as drawing "diamonds" rather than ISO rectangles.

You are correct I will update the PR

@kwvanderlinde
Copy link
Collaborator

kwvanderlinde commented Oct 31, 2023

Tested. The tooltip now refer to "isometric rectangles" as expected.

Separate to that, I noticed that drawing and FOW tools still use the term "diamond". For consistency, I'll make new issues to get those updated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants