Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add Genesys / FFG Starwars dice roller #4303

Closed
cwisniew opened this issue Sep 29, 2023 · 1 comment · Fixed by #4304
Closed

[Feature]: Add Genesys / FFG Starwars dice roller #4303

cwisniew opened this issue Sep 29, 2023 · 1 comment · Fixed by #4304
Assignees
Labels
feature Adding functionality that adds value

Comments

@cwisniew
Copy link
Member

Describe the Problem

The Narrative dice system used by FFG Starwars and many other Genesys games are not supported by MapTool and should be.

The Solution you'd like

Support the dice rollers above.

Alternatives that you've considered.

People have made macros to do these dice, but they are complicated.

Additional Context

No response

@cwisniew cwisniew added the feature Adding functionality that adds value label Sep 29, 2023
@cwisniew cwisniew self-assigned this Sep 29, 2023
@kwvanderlinde
Copy link
Collaborator

Took this for a spin. As far as I can tell, results align with expectations, though an expert in the system would be better equipped to decide that. I also did not try out every possibility yet.

The PR claims that gs.lastRoll.light and gs.lastRoll.dark are not set when using gs! rolls. But I found these variables are set the just return 0. Otherwise the variables seem to be aligning with expectations, including that sw.* are only set when rolling with sw!, and gs.* are only set when rolling with gs!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Status: Needs Testing
Development

Successfully merging a pull request may close this issue.

2 participants