Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp/bl808] add: drv_gpio #6856

Merged
merged 5 commits into from
Jan 16, 2023
Merged

[bsp/bl808] add: drv_gpio #6856

merged 5 commits into from
Jan 16, 2023

Conversation

Z8MAN8
Copy link
Contributor

@Z8MAN8 Z8MAN8 commented Jan 15, 2023

拉取/合并请求描述:(PR description)

[

在bl808开发板上进行测试

为什么提交这份PR (why to submit this PR)

添加gpio驱动

你的解决方案是什么 (what is your solution)

在什么测试环境下测试通过 (what is the test environment)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

请刷一下格式 https://github.com/mysterywolf/formatting

@Z8MAN8
Copy link
Contributor Author

Z8MAN8 commented Jan 15, 2023

请刷一下格式 https://github.com/mysterywolf/formatting

已格式化

@mysterywolf mysterywolf added the +1 Agree +1 label Jan 15, 2023
@BernardXiong
Copy link
Member

可以增加忽略,bl808的库代码可以排除在外。这样库代码后续跟着官方一起更新即可

@mysterywolf
Copy link
Member

忽略已经加了,只不过他扩大了format的范围,format多了,但是没有什么大问题。

bsp/bl808/m0/drivers/drv_gpio.c Outdated Show resolved Hide resolved
bsp/bl808/m0/drivers/drv_gpio.c Outdated Show resolved Hide resolved
bsp/bl808/m0/drivers/drv_gpio.c Outdated Show resolved Hide resolved
bsp/bl808/m0/drivers/drv_gpio.c Outdated Show resolved Hide resolved
@mysterywolf mysterywolf removed the +1 Agree +1 label Jan 16, 2023
Z8MAN8 and others added 2 commits January 16, 2023 11:43
Co-authored-by: Man, Jianting (Meco) <920369182@qq.com>
bsp/bl808/m0/drivers/drv_gpio.c Outdated Show resolved Hide resolved
bsp/bl808/m0/drivers/drv_gpio.c Outdated Show resolved Hide resolved
@mysterywolf mysterywolf added the +1 Agree +1 label Jan 16, 2023
@mysterywolf mysterywolf merged commit 84af32d into RT-Thread:master Jan 16, 2023
@Z8MAN8 Z8MAN8 deleted the feature branch January 16, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants