[stm32][softspi]soft spi attach函数问题解决方案 #6868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
请增加一下PR描述，在哪个板子上已经验证过了？ |
mysterywolf
reviewed
Jan 18, 2023
| @@ -30,23 +30,25 @@ static struct stm32_soft_spi_config soft_spi_config[] = | |||
| /** | |||
| * Attach the spi device to soft SPI bus, this function must be used after initialization. | |||
| */ | |||
| rt_err_t rt_hw_soft_spi_device_attach(const char *bus_name, const char *device_name, const char *pin_name) | |||
| rt_err_t rt_soft_spi_device_attach(const char *bus_name, const char *device_name, rt_base_t cs_pin) | |||
There was a problem hiding this comment.
Suggested change
| rt_err_t rt_soft_spi_device_attach(const char *bus_name, const char *device_name, rt_base_t cs_pin) | |
| rt_err_t rt_hw_softspi_device_attach(const char *bus_name, const char *device_name, rt_base_t cs_pin) |
There was a problem hiding this comment.
软件spi还是硬件spi 在注册接口上最后没有区别，否则上层应用/软件包在用的时候就会小有难受。这个地方再讨论一下
mysterywolf
approved these changes
Jan 19, 2023
wdfk-prog
added a commit
to wdfk-prog/ART-PI
that referenced
this pull request
Jan 29, 2023
* [softspi]soft spi attach函数问题解决方案 * 更改函数名 > RT-Thread/rt-thread#6868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
修改spi函数名称，并支持pin框架，已经在stm32f407-atk-explorer完成测试
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up