Optimised show_topics

[bhargavvader]

Possible solution to #1006 .
@tmylk could you review?

[tmylk]

remove duplicate code please

[tmylk]

Too much code duplication
Just add an extra if formatted block in the end that changes formatting

[bhargavvader]

Oh yes, that was quite stupid of me 💩
Will fix!

[bhargavvader]

@tmylk , removed duplicate code.

[tmylk]

Is there a performance improvement with %%timeit?

[bhargavvader]

Yeah, with the old method and 5 topics for the news_corpus dataset it was 100 loops, best of 3: 6.89 ms per loop, with the optimised one it was 100 loops, best of 3: 4.28 ms per loop

[tmylk]

hmm, that doesn't agree with the original report of

On my setup (500 topics, 100k words, learned with 500k documents), calling show_topics takes 30sec, with 28sec inside the 500 get_lambda() calls

[bhargavvader]

Could it maybe be because of the number of topics? Will increase number of topics and see what the difference is like. I only have 5 topics.

[tmylk]

Yes, let's test the reported case

[bhargavvader]

I got a fairly significant improvement (20 times faster) with 500 topics (vocab is smaller though, len is 44143).

For the old method:

1 loop, best of 3: 2.05 s per loop

For the optimised method:

10 loops, best of 3: 107 ms per loop

[tmylk]

Thanks a lot for the improvement!

[bhargavvader]

😄