Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed test for training (new fastText format) #1371

Merged
merged 1 commit into from
May 29, 2017

Conversation

prakhar2b
Copy link
Contributor

@prakhar2b prakhar2b commented May 28, 2017

Fix #1370
For the dataset that we used (lee) vocab_size in older fasttext format was 1762, but for newer format it's 1763. For loading (PR #1319 ), we have two separate tests now (1762 for older, and 1763 for newer).
cc @menshikh-iv

@menshikh-iv
Copy link
Contributor

Thank you, @prakhar2b

@menshikh-iv menshikh-iv merged commit f1df69a into piskvorky:develop May 29, 2017
@piskvorky
Copy link
Owner

piskvorky commented May 29, 2017

What was the reason for this bug, what happened?

Are there any more bugs like this?

@menshikh-iv
Copy link
Contributor

@piskvorky It's ok, I speak with @prakhar2b in gitter about it.

for the dataset that we used (lee) vocab_size in older fasttext format was 1762, but for newer format it's 1763. For loading (PR 1319), we have two separate tests (1762 for older, and 1763 for newer).`

Now, FastText saved data in new format, this was a problem of current test.

@piskvorky
Copy link
Owner

piskvorky commented May 30, 2017

That's good to know.

Try to keep the summary / gist of the explanation on Github too -- the repo is followed by many people, and also indexed by google. Knowledge that's Gitter-only is lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants