Use relative paths to notebooks in the same folder #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @vochicong, I think it's can be helpful, what do you think about this change @piskvorky? |
|
Looks good to me! 👍 As long as the links continue to work when viewed on github (which they seem to do). |
|
Thank you @vochicong 👍 |
vochicong
pushed a commit
to vochicong/gensim
that referenced
this pull request
Jun 14, 2017
More relative paths in notebooks, related to piskvorky#1407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative paths to notebooks in the same folder (same repository) enable me to follow the links in notebooks when doing experiments in my Jupyter environment, as well as when navigating notebooks in my fork.
I've also fixed the dead link to the Word2Vec and FastText comparison notebook.