Fix Mallet wrapper & test for HDPTransform #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
reviewed
Aug 31, 2017
| @@ -183,7 +183,7 @@ def __getitem__(self, bow, iterations=100): | |||
|
|
|||
| def load_word_topics(self): | |||
| logger.info("loading assigned topics from %s", self.fstate()) | |||
| word_topics = numpy.zeros((self.num_topics, self.num_terms), dtype=numpy.float32) | |||
| word_topics = numpy.zeros((self.num_topics, self.num_terms), dtype=numpy.float64) | |||
There was a problem hiding this comment.
Is this really needed? Double precision is rarely necessary.
There was a problem hiding this comment.
Double precision used for all TMs now.
There was a problem hiding this comment.
Question is "why"? Looks wasteful.
There was a problem hiding this comment.
I don't know, I don't implement TMs in gensim.
There was a problem hiding this comment.
That doesn't sound right. I'm pretty sure many models used to use single precision (RP and LSI, for sure).
Can you check when the change to double precision happened, and why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.