Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures FastText returns consistent dtypes #1638

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Ensures FastText returns consistent dtypes #1638

merged 1 commit into from
Oct 24, 2017

Conversation

mcobzarenco
Copy link
Contributor

Fix #1637

menshikh-iv
menshikh-iv suggested changes Oct 19, 2017
View reviewed changes
Copy link
Contributor

@menshikh-iv menshikh-iv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Please add test for fasttext (check that now all types is consistent)

@mcobzarenco
Copy link
Contributor Author

Cool! Will do.

@menshikh-iv
Copy link
Contributor

Ping @mcobzarenco, how is going?

@mcobzarenco
Copy link
Contributor Author

mcobzarenco commented Oct 24, 2017 •
edited
Loading

Sorry for the delay -- I now added a simple test to check that the dtypes are the same.

@mcobzarenco mcobzarenco force-pushed the fasttext-dtypes branch 3 times, most recently from b648db7 to c153f03 Compare October 24, 2017 11:02
@menshikh-iv
Copy link
Contributor

Thanks @mcobzarenco

@menshikh-iv menshikh-iv merged commit 7f23a2c into piskvorky:develop Oct 24, 2017
horpto pushed a commit to horpto/gensim that referenced this pull request Oct 28, 2017
@mcobzarenco @horpto
Fix FastText inconsistent dtype. Fix piskvorky#1637 (piskvorky#1638)
91549e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@menshikh-iv menshikh-iv menshikh-iv requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcobzarenco @menshikh-iv