Remove ignore of E731 #1689
Merged
Remove ignore of E731 #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horpto
force-pushed
the
refactoring-1644-E731
branch
from
8267d8e
to
04d7f87
Compare
menshikh-iv
suggested changes
Nov 3, 2017
gensim/test/test_atmodel.py
Outdated
| datapath = lambda fname: os.path.join(module_path, 'test_data', fname) | ||
|
|
||
|
|
||
| def datapath(fname): |
There was a problem hiding this comment.
please create utils file and move this function (replace to import everywhere).
gensim/test/test_fasttext_wrapper.py
Outdated
| def datapath(fname): | ||
| return os.path.join(module_path, 'test_data', fname) | ||
|
|
||
|
|
||
| def testfile(): |
gensim/test/test_ldamodel.py
Outdated
| @@ -25,8 +25,6 @@ | |||
| from gensim.test import basetmtests | |||
|
|
|||
| module_path = os.path.dirname(__file__) # needed because sample data files are located in the same folder | |||
| datapath = lambda fname: os.path.join(module_path, 'test_data', fname) | |||
|
|
|||
|
|
|||
| # set up vars used in testing ("Deerwester" from the web tutorial) | |||
| texts = [ | |||
menshikh-iv
suggested changes
Nov 6, 2017
gensim/test/test_atmodel.py
Outdated
| @@ -27,6 +24,7 @@ | |||
| from gensim.models import atmodel | |||
| from gensim import matutils | |||
| from gensim.test import basetmtests | |||
| from gensim.test.utils import (datapath, get_tmpfile) | |||
There was a problem hiding this comment.
useless () (here and anywhere)
| @@ -507,7 +498,7 @@ def testPersistence(self): | |||
| self.assertTrue(np.allclose(model.state.gamma, model2.state.gamma)) | |||
|
|
|||
| def testPersistenceIgnore(self): | |||
| fname = testfile('testPersistenceIgnore') | |||
| fname = get_tmpfile('gensim_models_atmodel_testPersistenceIgnore.tst') | |||
There was a problem hiding this comment.
it's a good idea to use same notation, what's your choice?
gensim/test/test_atmodel.py
Outdated
| @@ -36,9 +34,6 @@ | |||
| # increases the bound. | |||
| # Test that models are compatiple across versions, as done in LdaModel. | |||
|
|
|||
| module_path = os.path.dirname(__file__) # needed because sample data files are located in the same folder | |||
| datapath = lambda fname: os.path.join(module_path, 'test_data', fname) | |||
|
|
|||
| # set up vars used in testing ("Deerwester" from the web tutorial) | |||
| texts = [ | |||
There was a problem hiding this comment.
This text used in many places, maybe move to utils too?
There was a problem hiding this comment.
hmm,
- it's data, not utils/functions
- maybe in another PR ?
There was a problem hiding this comment.
- Yeah, but it's "common resource", I think that's fine.
- No need to create distinct PR for this change.
There was a problem hiding this comment.
- Ok, I'll fix it.
- small PR is better to review and faster to merge.
| module_path = os.path.dirname(__file__) # needed because sample data files are located in the same folder | ||
|
|
||
|
|
||
| def datapath(fname): |
There was a problem hiding this comment.
Please add docstring in numpy-style for both functions
gensim/utils.py
Outdated
| compress = False | ||
| subname = lambda *args: '.'.join(list(args) + ['npy']) | ||
| return compress, subname | ||
| [compress, suffix] = (True, 'npz') if fname.endswith('.gz') or fname.endswith('.bz2') else (False, 'npy') |
|
close/open for init AppVeyor |
menshikh-iv
approved these changes
Nov 7, 2017
|
Great work @horpto🥇, you are very active in the gensim project 👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.