Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Similarity.query_shards in multiprocessing case #2044

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

bohea
Copy link
Contributor

@bohea bohea commented May 11, 2018

Python3.6

iterable to list

@menshikh-iv menshikh-iv changed the title Update docsim.py Fix bug in Similarity.query_shards with multiple shards & parallel query Jun 22, 2018
@menshikh-iv
Copy link
Contributor

wow, I didn't think that someone use this functionality, thanks for your fix and congratz with first contribution @bohea ⭐ 👍

@menshikh-iv menshikh-iv changed the title Fix bug in Similarity.query_shards with multiple shards & parallel query Fix bug in Similarity.query_shards in multiprocessing case Jun 22, 2018
@menshikh-iv menshikh-iv merged commit fd6f6eb into piskvorky:develop Jun 22, 2018
@piskvorky
Copy link
Owner

I don't think PARALLEL_SHARDS even works any more… Curious about the use-case here.

@menshikh-iv
Copy link
Contributor

@piskvorky this can be "monkey-patched" (activated) if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants