Fix default -> auto prior parameter in documentation for lda-related models
#2156
Conversation
Change "default" to "auto" since there is no handling on the value "default".
There was a problem hiding this comment.
Thank you @Laubeee, please make the same update for others and I'll merge current PR
| @@ -369,7 +369,7 @@ def __init__(self, corpus=None, num_topics=100, id2word=None, | |||
| Alternatively default prior selecting strategies can be employed by supplying a string: | |||
|
|
|||
| * 'asymmetric': Uses a fixed normalized asymmetric prior of `1.0 / topicno`. | |||
| * 'default': Learns an asymmetric prior from the corpus. | |||
| * 'auto': Learns an asymmetric prior from the corpus. | |||
There was a problem hiding this comment.
please update this in other places too
https://github.com/RaRe-Technologies/gensim/blob/56070fbb772259d434af957f46b4cda8954f4927/gensim/models/ldamodel.py#L534
https://github.com/RaRe-Technologies/gensim/blob/56070fbb772259d434af957f46b4cda8954f4927/gensim/models/ldamulticore.py#L132
https://github.com/RaRe-Technologies/gensim/blob/466b32fe6b5631403fe5be8c16233df3d61a373b/gensim/sklearn_api/ldamodel.py#L64
https://github.com/RaRe-Technologies/gensim/blob/466b32fe6b5631403fe5be8c16233df3d61a373b/gensim/sklearn_api/atmodel.py#L86
menshikh-iv
changed the title
default -> auto prior parameter in documentation for lda-related models
|
Oh alright didn't catch those |
gensim/sklearn_api/ldamodel.py
Outdated
| @@ -61,7 +61,7 @@ def __init__(self, num_topics=100, id2word=None, chunksize=2000, passes=1, updat | |||
| Alternatively default prior selecting strategies can be employed by supplying a string: | |||
|
|
|||
| * 'asymmetric': Uses a fixed normalized assymetric prior of `1.0 / topicno`. | |||
| * 'default': Learns an assymetric prior from the corpus. | |||
| * 'auto': Learns an assymetric prior from the corpus. | |||
There was a problem hiding this comment.
assymetric => asymmetric (here and elsewhere)
|
Congratz with the first contribution @Laubeee 👍 |
Change "default" to "auto" since there is no handling on the value "default".