[MRG] Docs: Update Hoffman paper link for Online LDA #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure in one of the Windows runs is unrelated to the change - maybe some instability/over-specificity in that LDA test? So no reason this shouldn't be merged ASAP. |
|
I reran that test, but actually flake8 (code style check) is failing too, with "line too long": https://travis-ci.org/github/RaRe-Technologies/gensim/jobs/711476287#L604 @xh2 can you split that line in two? Then we're good to merge. |
piskvorky
changed the title
piskvorky
requested changes
Jul 26, 2020
piskvorky
approved these changes
Jul 26, 2020
|
This time the build failure is unrelated to the change. Seems to be connection error with Visdom. This can now be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current link to Hoffman's paper is outdated and results in this page:
Updating to his papers page as per the link on his website.
If the actual paper's link is desired, it will be this link: http://papers.nips.cc/paper/3902-online-learning-for-latent-dirichlet-allocation.pdf