-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove on_batch_begin and on_batch_end callbacks #3078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. But tests are failing + needs a mention in the Migration notes too.
The tests are failing for an unrelated reason.
Not sure what's going on there. If it doesn't self-resolve, I'll have to investigate explicitly later. Updated the migration docs here. |
Alright, I managed to work around the unrelated test failures. Please have a look at the PR and the migration note updates and let me know if this is good to merge. |
Co-authored-by: Radim Řehůřek <radimrehurek@seznam.cz>
Looks good, though if |
Fix #2182
I added a documentation note to avoid using these callbacks. With Python, we cannot prevent people from implementing those callback handlers in their own subclasses, so a documentation warning is the most that we can do.