Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LSI dispatcher CLI param for number of jobs optional #3115

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Make LSI dispatcher CLI param for number of jobs optional #3115

merged 2 commits into from
Apr 28, 2021

Conversation

robguinness
Copy link
Contributor

Closes #3104.

This was referenced Apr 12, 2021
Closed
Closed
@mpenkov
Copy link
Collaborator

mpenkov commented Apr 13, 2021

CI failure appears to be unrelated to the PR. I'm rerunning the failed build just to be sure.

mpenkov
mpenkov reviewed Apr 13, 2021
View reviewed changes
gensim/models/lsi_dispatcher.py Outdated
nargs='?',
type=int,
help='Maximum number of jobs to be kept pre-fetched in the queue.',
default=MAX_JOBS_QUEUE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default=MAX_JOBS_QUEUE
default=MAX_JOBS_QUEUE,

@mpenkov
Copy link
Collaborator

mpenkov commented Apr 13, 2021

CI failure appears to be unrelated to the PR. I'm rerunning the failed build just to be sure.

@robguinness Can you please make this PR editable to maintaners? See https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork.

@robguinness
Copy link
Contributor Author

CI failure appears to be unrelated to the PR. I'm rerunning the failed build just to be sure.

@robguinness Can you please make this PR editable to maintaners? See https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork.

Hi @mpenkov, I don't actually see that option to make the PR editable. But I can push that change.

@robguinness
Copy link
Contributor Author

Commit has been added.

@mpenkov mpenkov merged commit 5a02b3d into piskvorky:develop Apr 28, 2021
@mpenkov
Copy link
Collaborator

mpenkov commented Apr 28, 2021

OK, merged. Thank you @robguinness !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpenkov mpenkov mpenkov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsi_dispatcher is not working from command-line when not specifying maxsize argument
2 participants
@robguinness @mpenkov