Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unicode string incompatibility in gensim.similarities.fastss.editdist #3178

Merged
merged 5 commits into from
Jun 29, 2021
Merged

Fix Unicode string incompatibility in gensim.similarities.fastss.editdist #3178

merged 5 commits into from
Jun 29, 2021

Conversation

Witiko
Copy link
Contributor

@Witiko Witiko commented Jun 21, 2021 •
edited
Loading

Closes #3177:

$ pip install git+https://github.com/witiko/gensim.git@feature/fix-editdist-unicode
$ python3
>>> from gensim.similarities.fastss import editdist
>>>
>>> editdist('Žižka', 'šiška')
2
>>> editdist('Žižka', 'Zizka')
2

@Witiko Witiko mentioned this pull request Jun 21, 2021
Closed
@mpenkov
Copy link
Collaborator

mpenkov commented Jun 22, 2021

Very good. Can you please add a couple of unit tests to prevent regressions?

@Witiko
Copy link
Contributor Author

Witiko commented Jun 22, 2021

@mpenkov Not a problem. I added not just a couple, but four unit tests.

mpenkov
mpenkov approved these changes Jun 29, 2021
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you @Witiko !

@mpenkov mpenkov changed the title Do not expect the same Unicode kind in gensim.similarities.fastss.editdist Fix Unicode string incompatibility in gensim.similarities.fastss.editdist Jun 29, 2021
@mpenkov mpenkov merged commit a164685 into piskvorky:develop Jun 29, 2021
@gojomo gojomo mentioned this pull request Jul 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpenkov mpenkov mpenkov approved these changes

@piskvorky piskvorky piskvorky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible types of unicode strings in gensim.similarities.fastss.editdist
3 participants
@Witiko @mpenkov @piskvorky