Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the licence link to LGPLv2.1 #3471

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

ERijck
Copy link
Contributor

@ERijck ERijck commented May 11, 2023

No description provided.

@piskvorky
Copy link
Owner

@pabs3 CC – please review.

@piskvorky
Copy link
Owner

Whoa, what's going on. Why is the PR so large?

@pabs3
Copy link
Contributor

pabs3 commented May 12, 2023

Looks like @ERijck merged main back into the my_flsa_fixes branch they used to submit this PR, making it huge. I suggest closing this PR, rebasing instead of merging and then resubmitting the PR.

develop...ERijck:gensim:my_flsa_fixes

@PabloMosUU
Copy link

PabloMosUU commented Jun 1, 2023

@pabs3 @piskvorky : I am a collaborator of @ERijck . We have undone the merge that had caused the big pull request. The change is now only the license change, as you can see. Is this sufficient to merge the pull request?

@mpenkov
Copy link
Collaborator

mpenkov commented Aug 23, 2023

@piskvorky Should be good to merge now, right?

@mpenkov mpenkov added this to the 4.3.2 milestone Aug 23, 2023
@piskvorky piskvorky merged commit ce8b45e into piskvorky:flsa_fixes Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants