Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] DTM Tutorial Notebook and changes #831

Merged
merged 7 commits into from
Aug 25, 2016

Conversation

bhargavvader
Copy link
Contributor

Will work on updated Tutorial notebook here, and make changes to ldaseqmodel.

First step I've done is to completely remove the seq_corpus class, to make it easier to get a constant memory footprint.

"""

doc_topic = numpy.copy(self.gammas)
doc_topic /= doc_topic.sum(axis=1)[:, numpy.newaxis]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply self.gammas / self.gammas.sum(axis=1)[:, numpy.newaxis]? Are you running out of memory?

If so, put a clear comment to that effect here, so somebody doesn't accidentally "fix" the code later.

@bhargavvader
Copy link
Contributor Author

bhargavvader commented Aug 22, 2016

@piskvorky could you review the rest of the code as well? I'm guessing there will be other performance/style issues which I might have missed out on and would be good to address all of it at once. I've also updated the notebook, so would be awesome if you could have a look at that as well.

@tmylk tmylk merged commit 70b78c5 into piskvorky:develop Aug 25, 2016
@bhargavvader bhargavvader deleted the DTM_todos branch February 23, 2017 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants