Fix for issue #979 #986
Merged
Fix for issue #979 #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: WMD Earth mover Distance for sentences that contain a single word return inf Fix: Return float 0.0 when the dictionary size is 1 (both sentences are composed with the same token)
|
This is the relevant open issue: |
|
Thanks for the PR! |
anmolgulati
added a commit
to anmolgulati/gensim
that referenced
this pull request
Oct 31, 2016
tmylk
pushed a commit
that referenced
this pull request
Nov 13, 2016
* updated refactor * commit missed file * docstring added * more refactoring * add missing docstring * fix docstring format * clearer docstring * minor typo in word2vec wmdistance * pyemd error in keyedvecs * relative import of keyedvecs from word2vec fails * bug in init_sims in word2vec * property descriptors for syn0, syn0norm, index2word, vocab - fixes bug in saving * tests for loading older word2vec models * backwards compatibility for loading older models * test for syn0norm not saved to file * syn0norm not saved to file for KeyedVectors * tests and fix for accuracy * minor bug in finalized vocab check * warnings for direct syn0/syn0norm access * fixes use of most_similar in accuracy * changes logging level to ERROR in word2vec tests * renames kv to wv in word2vec * minor bugs with checking existence of syn0 * replaces syn0 and syn0norm with wv.syn0 and wv.syn0norm in tests and cython files * adds changelog * updates tests for loading word2vec models for different python versions * Added separate word2vec model explicitly for python version 3.4. * Added saved word2vec model for python 3.4 files * Removed blank line in test_wikicorpus.py * Increased window size in test_sg_hs_online * PR #986 merged in wmd in keyedvectors.py * Added deprecation warnings in Word2vec class attributes for future releases * Merged rare/develop into keyedvecs removing conflicts. * Merged rare/develop into keyedvecs and resolved conflicts. * Changed numpy to np in test_word2vec.py * Increased window size in test_cbow_hs_online * Removed blank line in test_ldamodel, work around for Travis-CI issue #971 * Removed logging during import
ghost
mentioned this pull request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: WMD Earth mover Distance for sentences that contain a single word return inf
Fix: Return float 0.0 when the dictionary size is 1 (both sentences are composed with the same token)