Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data transformations #2

Open
km1414 opened this issue May 12, 2019 · 0 comments
Open

Data transformations #2

km1414 opened this issue May 12, 2019 · 0 comments

Comments

@km1414
Copy link

km1414 commented May 12, 2019

Can you explain, why in min_max_scale and min_max_scale functions (in helpers/utils.py) all data splits are transformed using fit_transform(), instead of using fit_transform() on training part and transform() on others?

Trading-Bot/helpers/utils.py

Line 203 in 5b375d8

input_train_pca = pca.fit_transform(input_train)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@km1414