Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint functionality for chat method in rasa.jupyter #6051

Closed
1 task done
mcminis1 opened this issue Jun 23, 2020 · 10 comments
Closed
1 task done

Add endpoint functionality for chat method in rasa.jupyter #6051

mcminis1 opened this issue Jun 23, 2020 · 10 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@mcminis1
Copy link
Contributor

mcminis1 commented Jun 23, 2020

Description of Problem:
As a jupyter notebook user I am unable to access my custom actions server using the jupyter python sdk.

Overview of the Solution:
This is trivial to implement using an additional kwarg in rasa.jupyter.chat for the endpoints file.

Definition of Done:

  • Feature described the docs
@mcminis1 mcminis1 added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Jun 23, 2020
@mcminis1
Copy link
Contributor Author

Proposed solution would be used as follows.

from rasa.jupyter import chat
chat(model_path, endpoints)

@mcminis1
Copy link
Contributor Author

with the chat method as:

def chat(
    model_path: Optional[Text] = None,
    endpoints: Optional[Text] = None,
    agent: Optional["Agent"] = None,
    interpreter: Optional[NaturalLanguageInterpreter] = None,
) -> None:

@sara-tagger
Copy link
Collaborator

Thanks for submitting this feature request 🚀 @TyDunn will get back to you about it soon! ✨

@mcminis1
Copy link
Contributor Author

corresponding PR:
#6052

@mcminis1
Copy link
Contributor Author

@TyDunn Any thoughts on this improvement? The PR is ready to go.

@TyDunn
Copy link
Contributor

TyDunn commented Jun 26, 2020

@mcminis1 I see @rgstephens needs to review it. That will be the next step 👍

@mcminis1
Copy link
Contributor Author

@TyDunn looks like it got signoff. How does it get merged in?

@TyDunn
Copy link
Contributor

TyDunn commented Jul 13, 2020

@mcminis1 Now that @rgstephens has approved it and the PR has past checks, it's up to him to merge it

@mcminis1
Copy link
Contributor Author

It's been 27 days since approval. Is that a normal wait time for a PR to get merged? @TyDunn

@wochinge
Copy link
Contributor

fixed by #6052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

4 participants