Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux : Install editor from "Editor Version", and maybe an update notification #43

Open
hunabku94 opened this issue Jul 10, 2024 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@hunabku94
Copy link

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
A way to install editor, and if one is, an icon or something to advert there is an update

Describe alternatives you've considered

Additional context

@Ravbug
Copy link
Owner

Ravbug commented Jul 10, 2024

New editor versions can be installed from the Editor tab.

@hunabku94
Copy link
Author

hunabku94 commented Jul 11, 2024

Maybe the linux release, or i'm tired but where can i please ?

qNlXscn

@Ravbug
Copy link
Owner

Ravbug commented Jul 11, 2024

The Linux version currently doesn't support installing Editor versions, sorry. You're welcome to make a PR.

@Ravbug Ravbug added the enhancement New feature or request label Jul 11, 2024
@hunabku94
Copy link
Author

I don't know C++, but i can't totaly help for the linux part ;-)

@Ravbug Ravbug added the help wanted Extra attention is needed label Jul 12, 2024
@hunabku94
Copy link
Author

i know some C#, can help, maybe

@hunabku94 hunabku94 changed the title Install editor from "Editor Version", and maybe an update notification Linux : Install editor from "Editor Version", and maybe an update notification Oct 4, 2024
@hunabku94
Copy link
Author

hunabku94 commented Oct 4, 2024

So, i have time and i'm motivated to add this feature.

I get an eye to the code and it's hard to me to understand the structure and what i need to modify.

Can we work together to do that feature ?

@Ravbug
Copy link
Owner

Ravbug commented Oct 4, 2024

This line of code disables the "Install New" button on Linux. Removing the linux check will re-enable the button:

#if defined __linux__
launchHubBtn->Hide();
#endif

The code for the Install New dialog and associated functionality lives in add_install_dlg_derived.cpp. The Install Via (Official) Hub button might work out-of-the-box, but I haven't tested it as I don't currently have a machine running Linux.

Beyond that, installing outside the official hub will require some additional effort. You'll likely need to add a new case to this section of code:

// download the file
string url = "https://download.unity3d.com/download_unity/" + data.hashcode + "/UnityDownloadAssistant" +
#ifdef __APPLE__
".dmg";
#elif defined _WIN32
".exe";
#elif __linux__
#else
#error This platform is not supported.

as well as this section of code to launch their installer:
// open the file
wxCommandEvent lnevt(executeEvt);
#ifdef __APPLE__
lnevt.SetString(fmt::format("open \"{}\"", outpath));
#elif defined _WIN32
lnevt.SetString(fmt::format("\"{}\"", outpath));
#endif

@hunabku94
Copy link
Author

Thanks i will see for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants