Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better detecting of supporting features #44

Open
termi opened this issue Feb 3, 2012 · 6 comments
Open

Better detecting of supporting features #44

termi opened this issue Feb 3, 2012 · 6 comments

Comments

@termi
Copy link
Collaborator

termi commented Feb 3, 2012

As long as feature not using yet, we need better detecting of supporting features.
For example: classList is supported by Opera 11, but it not in Element.prototype so

if (!hasOwnProperty.call(Element.prototype, 'classList'))

code invalid for detecting classList

addShimToInterface function
if (!hasOwnProperty.call(proto, name)) line

@Raynos
Copy link
Owner

Raynos commented Feb 3, 2012

The optimum solution is rewrite using feature. That's why I wrote feature.

@Raynos
Copy link
Owner

Raynos commented Apr 1, 2012

Started rewriting using feature in the feature branch

@termi
Copy link
Collaborator Author

termi commented Apr 2, 2012

Hi. I was busy last 1,5 month. I want to proceed working on DOM-shim, but I have some questions. What method of communication do you prefer? My skype is termi_uc

@Raynos
Copy link
Owner

Raynos commented Apr 2, 2012

Ideally discussion should be recorded through the github issues list.

It's fine to have discussions over skype and summarize through github.

@termi
Copy link
Collaborator Author

termi commented Apr 2, 2012

I need to clarify some code in newest commit

@Raynos
Copy link
Owner

Raynos commented Apr 2, 2012

I've added you over skype, we can talk when's convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants