Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path bounding box calculation is incorrect #687

Closed
RazrFalcon opened this issue Dec 3, 2023 · 2 comments
Closed

Path bounding box calculation is incorrect #687

RazrFalcon opened this issue Dec 3, 2023 · 2 comments
Labels
bug

Comments

@RazrFalcon
Copy link
Collaborator

RazrFalcon commented Dec 3, 2023 •
edited
Loading

As shown in the spec, a path bounding box should not include curve points (illustration 3). But this is exactly what resvg does. And specifically tiny-skia, which is used for getting the bbox...

Seems like it's broken since v0.34. Before we had a custom path bbox calculation algorithm.
And none of the tests were affected by it...
@RazrFalcon RazrFalcon added the bug label Dec 3, 2023
@RazrFalcon
Copy link
Collaborator Author

Nope, still broken.

@RazrFalcon RazrFalcon reopened this Dec 17, 2023
@yisibl yisibl mentioned this issue Dec 17, 2023
Open
@RazrFalcon
Copy link
Collaborator Author

RazrFalcon commented Dec 19, 2023 •
edited
Loading

Miss click... I was planning to close #549 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RazrFalcon