You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I traced this code back to 270c856 that comes from this discussion. Those three lines ended up commented out after this message, that reports some issues with such feature enabled. However:
That is a long time ago, like gcc 4.7 time ago.
All the uses of HAS_VARIADIC_TEMPLATES in the current codebase are in the #if defined(HAS_VARIADIC_TEMPLATES) || defined(RCPP_USING_CXX11) checks added by @andrjohns as part of his PR.
This means that everything that defining such a macro enables is already enabled.
And it's already on CRAN and well tested.
So uncommenting these 3 lines has no impact beyond correctly reporting this capability. Do you want me to open a PR? Or should we kindly ask @andrjohns to enable such defines as part of #1328, and then maybe also simplify the above checks by dropping the || defined(RCPP_USING_CXX11) part?
I like both cleanup aspects. We can surely remove the commented-out and unused bit, and also amplifying the actual usefulness of the usage seems like a good idea. @andrjohns is closest to the metal here. Any thoughts?
I see:
This is checked here:
Rcpp/src/api.cpp
Lines 174 to 178 in dfa585d
But
HAS_VARIADIC_TEMPLATES
is never set (note that the defines are commented out):Rcpp/inst/include/Rcpp/platform/compiler.h
Lines 66 to 97 in dfa585d
The text was updated successfully, but these errors were encountered: