-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline text style markup #10
Comments
That definitely looks like a much more user-friendly way to manage inline styles compared to the style array. Do you think it needs to be its own class, or could we introduce this templating to the base TextContainer class? |
FYI - I'm planning further refactoring / tidy once I get code coverage working in #9 |
It currently is |
I noticed duplication that could be removed by creating a shared base class for Text, PathText, and CharacterText. It's not part of the original version of txtjs. |
I see. Then that could definitely go in here 🙂 |
It does seems like it could remain decoupled however - ie, we could have most of the implementation stored in a separate class, and the base class just makes use of it. Do you want to create a draft PR for implementation feedback? |
Could be decoupled in some kind of utility class, yes. Will try to provide a draft PR this (or next) week. |
Hi and thanks for doing this :)
I'm working on a RichText class and syntax that would allow faster and simpler rich formatting. Here is a very early screenshot of what it can do:
It's working but I'm not sure about the formatting syntax itself (will work on improving that). Also, I'd like to allow easier bold and italic switching, with predefined and associated font names.
Any thoughts?
The text was updated successfully, but these errors were encountered: