Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Export internal data documents provider patch #3830

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

timschneeb
Copy link
Contributor

@timschneeb timschneeb commented Oct 27, 2024

This PR adds an universal patch that registers a DocumentsProvider with access to the internal app storage of the patched app. This is useful if you want to inspect or manipulate protected files like databases or shared preferences of an app without root access.

The documents provider is accessible through the system file picker and allows 3rd-party file explorer apps (like MiXplorer) to mount it as a virtual storage device.

This change removes the prior ChangeDataDirectoryLocationPath that tries to accomplish a similar behavior by redirecting the internal data storage to the external data storage, however, it has a few problems. It does not affect file operations in native libraries or in apps with hardcoded /data/data/{pkgName} paths. It also only redirects calls to Context.getDir(), but not getFilesDir(), getCacheDir(), etc.. which also point to the internal app storage.

Screenshots of a patched app in the system file picker

Screenshot_20241027_161002_Files
Screenshot_20241027_161014_Files

@oSumAtrIX
Copy link
Member

There's already another patch ChangeDataDirectoryLocationPath that tries to accomplish a similar behavior by redirecting the internal data storage to the external data storage, however, it has a few problems. It does not affect file operations in native libraries or in apps with hardcoded /data/data/{pkgName} paths. It also only redirects calls to Context.getDir(), but not getFilesDir(), getCacheDir(), etc.. which also point to the internal app storage

Would the patch be subject to be removed in favour of this one?

@timschneeb
Copy link
Contributor Author

I think it can be removed. This patch provides pretty much the same result, just with a different method.

@oSumAtrIX oSumAtrIX force-pushed the dev branch 3 times, most recently from c0cd9d2 to 2ace07d Compare November 6, 2024 16:19
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the internal-data-doc-provider branch 3 times, most recently from 10b4808 to 06d25c0 Compare November 19, 2024 07:32
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the internal-data-doc-provider branch from 06d25c0 to 73f2638 Compare November 19, 2024 07:33
@oSumAtrIX oSumAtrIX merged commit cb22f65 into ReVanced:dev Dec 9, 2024
1 check passed
Copy link

welcome bot commented Dec 9, 2024

Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution.

github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
# [5.4.0-dev.2](v5.4.0-dev.1...v5.4.0-dev.2) (2024-12-09)

### Bug Fixes

* **TikTok - SIM Spoof:** Change patch to default off to fix login ([#4084](#4084)) ([f4659a3](f4659a3))

### Features

* Add Internal data documents provider patch ([#3830](#3830)) ([cb22f65](cb22f65))
github-actions bot pushed a commit to attercopdazzler/revanced-patches-temp that referenced this pull request Dec 11, 2024
# [5.4.0](v5.3.0...v5.4.0) (2024-12-11)

### Bug Fixes

* **TikTok - Settings:** Use correct colors for dark mode ([ReVanced#4087](https://github.com/attercopdazzler/revanced-patches-temp/issues/4087)) ([6bd22ff](6bd22ff))
* **TikTok - SIM Spoof:** Change patch to default off to fix login ([ReVanced#4084](https://github.com/attercopdazzler/revanced-patches-temp/issues/4084)) ([f4659a3](f4659a3))
* **YouTube - Spoof video streams:** Fix error toast that is sometimes shown ([ReVanced#4090](https://github.com/attercopdazzler/revanced-patches-temp/issues/4090)) ([4c46cb2](4c46cb2))
* **YouTube - Spoof video streams:** Resolve playback of age restricted videos ([ReVanced#4096](https://github.com/attercopdazzler/revanced-patches-temp/issues/4096)) ([839a404](839a404))

### Features

* Add Internal data documents provider patch ([ReVanced#3830](https://github.com/attercopdazzler/revanced-patches-temp/issues/3830)) ([cb22f65](cb22f65))
* **Change package name:** Add options to change provider and permission package names to handle installation conflicts ([75c740c](75c740c))
* **Twitch:** Make patches compatible with latest versions ([51b5105](51b5105))
github-actions bot pushed a commit that referenced this pull request Dec 14, 2024
# [5.4.0](v5.3.0...v5.4.0) (2024-12-14)

### Bug Fixes

* **GmsCore support:** Adjust presentation of battery optimization dialog  ([#4091](#4091)) ([5d8fc1b](5d8fc1b))
* **TikTok - Settings:** Use correct colors for dark mode ([#4087](#4087)) ([6bd22ff](6bd22ff))
* **TikTok - SIM Spoof:** Change patch to default off to fix login ([#4084](#4084)) ([f4659a3](f4659a3))
* **YouTube - Hide ads:** Hide new type of featured promotions ([#4113](#4113)) ([13c7592](13c7592))
* **YouTube - Spoof video streams:** Fix error toast that is sometimes shown ([#4090](#4090)) ([4c46cb2](4c46cb2))
* **YouTube - Spoof video streams:** Resolve playback of age restricted videos ([#4096](#4096)) ([839a404](839a404))
* **YouTube Music - Bypass certificate checks:** Add a recommended target version ([#4104](#4104)) ([17a5a6c](17a5a6c))
* **YouTube Music - Spoof video streams:** Disable stable volume ([#4097](#4097)) ([16bb9df](16bb9df))

### Features

* Add Internal data documents provider patch ([#3830](#3830)) ([cb22f65](cb22f65))
* **Change package name:** Add options to change provider and permission package names to handle installation conflicts ([75c740c](75c740c))
* **Twitch:** Make patches compatible with latest versions ([#4099](#4099)) ([eecfbb7](eecfbb7))
* **YouTube - Comments:** Add `Hide 'Chat summary'` ([#4110](#4110)) ([269493c](269493c))
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat: Add Internal data documents provider patch feat: Add Export internal data documents provider patch Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants